From 49f77fff1495c0a2050fb18f9b1fc627839bbfc2 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade Date: Wed, 3 Dec 2008 05:43:34 -0200 Subject: Rework symbol visibility for easier maintenance Save in a few special cases, _X_EXPORT should not be used in C source files. Instead, it should be used in headers, and the proper C source include that header. Some special cases are symbols that need to be shared between modules, but not expected to be used by external drivers, and symbols that are accessible via LoaderSymbol/dlopen. This patch also adds conditionally some new sdk header files, depending on extensions enabled. These files were added to match pattern for other extensions/modules, that is, have the headers "deciding" symbol visibility in the sdk. These headers are: o Xext/panoramiXsrv.h, Xext/panoramiX.h o fbpict.h (unconditionally) o vidmodeproc.h o mioverlay.h (unconditionally, used only by xaa) o xfixes.h (unconditionally, symbols required by dri2) LoaderSymbol and similar functions now don't have different prototypes, in loaderProcs.h and xf86Module.h, so that both headers can be included, without the need of defining IN_LOADER. xf86NewInputDevice() device prototype readded to xf86Xinput.h, but not exported (and with a comment about it). --- randr/randr.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'randr/randr.c') diff --git a/randr/randr.c b/randr/randr.c index 5a60cc983..230d816a3 100644 --- a/randr/randr.c +++ b/randr/randr.c @@ -53,14 +53,14 @@ static int RRNScreens; static int ProcRRDispatch (ClientPtr pClient); static int SProcRRDispatch (ClientPtr pClient); -_X_EXPORT int RREventBase; -_X_EXPORT int RRErrorBase; -_X_EXPORT RESTYPE RRClientType, RREventType; /* resource types for event masks */ +int RREventBase; +int RRErrorBase; +RESTYPE RRClientType, RREventType; /* resource types for event masks */ static int RRClientPrivateKeyIndex; -_X_EXPORT DevPrivateKey RRClientPrivateKey = &RRClientPrivateKeyIndex; +DevPrivateKey RRClientPrivateKey = &RRClientPrivateKeyIndex; static int rrPrivKeyIndex; -_X_EXPORT DevPrivateKey rrPrivKey = &rrPrivKeyIndex; +DevPrivateKey rrPrivKey = &rrPrivKeyIndex; static void RRClientCallback (CallbackListPtr *list, @@ -196,7 +196,7 @@ SRRNotifyEvent (xEvent *from, static int RRGeneration; -_X_EXPORT Bool RRInit (void) +Bool RRInit (void) { if (RRGeneration != serverGeneration) { @@ -211,7 +211,7 @@ _X_EXPORT Bool RRInit (void) return TRUE; } -_X_EXPORT Bool RRScreenInit(ScreenPtr pScreen) +Bool RRScreenInit(ScreenPtr pScreen) { rrScrPrivPtr pScrPriv; @@ -314,7 +314,7 @@ RRFreeEvents (pointer data, XID id) return 1; } -_X_EXPORT void +void RRExtensionInit (void) { ExtensionEntry *extEntry; @@ -398,7 +398,7 @@ TellChanged (WindowPtr pWin, pointer value) /* * Something changed; send events and adjust pointer position */ -_X_EXPORT void +void RRTellChanged (ScreenPtr pScreen) { rrScrPriv (pScreen); @@ -431,7 +431,7 @@ RRTellChanged (ScreenPtr pScreen) * Return the first output which is connected to an active CRTC * Used in emulating 1.0 behaviour */ -_X_EXPORT RROutputPtr +RROutputPtr RRFirstOutput (ScreenPtr pScreen) { rrScrPriv(pScreen); @@ -451,7 +451,7 @@ RRFirstOutput (ScreenPtr pScreen) return NULL; } -_X_EXPORT CARD16 +CARD16 RRVerticalRefresh (xRRModeInfo *mode) { CARD32 refresh; -- cgit v1.2.3