From 49f77fff1495c0a2050fb18f9b1fc627839bbfc2 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade Date: Wed, 3 Dec 2008 05:43:34 -0200 Subject: Rework symbol visibility for easier maintenance Save in a few special cases, _X_EXPORT should not be used in C source files. Instead, it should be used in headers, and the proper C source include that header. Some special cases are symbols that need to be shared between modules, but not expected to be used by external drivers, and symbols that are accessible via LoaderSymbol/dlopen. This patch also adds conditionally some new sdk header files, depending on extensions enabled. These files were added to match pattern for other extensions/modules, that is, have the headers "deciding" symbol visibility in the sdk. These headers are: o Xext/panoramiXsrv.h, Xext/panoramiX.h o fbpict.h (unconditionally) o vidmodeproc.h o mioverlay.h (unconditionally, used only by xaa) o xfixes.h (unconditionally, symbols required by dri2) LoaderSymbol and similar functions now don't have different prototypes, in loaderProcs.h and xf86Module.h, so that both headers can be included, without the need of defining IN_LOADER. xf86NewInputDevice() device prototype readded to xf86Xinput.h, but not exported (and with a comment about it). --- config/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'config') diff --git a/config/config.c b/config/config.c index b4737f8ba..882b699a0 100644 --- a/config/config.c +++ b/config/config.c @@ -31,7 +31,7 @@ #include "hotplug.h" #include "config-backends.h" -_X_EXPORT void +void config_init() { #if defined(CONFIG_DBUS_API) || defined(CONFIG_HAL) @@ -51,7 +51,7 @@ config_init() #endif } -_X_EXPORT void +void config_fini() { #if defined(CONFIG_DBUS_API) || defined(CONFIG_HAL) -- cgit v1.2.3