summaryrefslogtreecommitdiff
path: root/xkb
diff options
context:
space:
mode:
authorJamey Sharp <jamey@minilop.net>2010-05-15 12:31:34 -0700
committerJamey Sharp <jamey@minilop.net>2010-05-19 12:32:34 -0700
commit4b9600a4167427a8fe88bca9b738c9a99cac9469 (patch)
treea22ef3ebd07d5561041ae1a2483f279eaeaa0e6b /xkb
parentee9cd2df4a5af66c6b7073563785b8aef61fcdb8 (diff)
Make WriteEventsToClient/WriteToClient no-op on fake or dead clients.
This matches the test in TryClientEvents, and is a superset of tests done by the callers of these functions. The consequence of forgetting these tests is a server crash, so they're always desirable. In my opinion, it's better to not require the callers to remember to do these checks. For callers that don't do very much work before calling WriteToClient or WriteEventsToClient, I've removed the redundant checks. hw/xquartz/xpr/appledri.c has an interesting case: While its check for "client == NULL" appears redundant with the test in WriteEventsToClient, it dereferences client to get the sequence number. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=27497 Signed-off-by: Jamey Sharp <jamey@minilop.net> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Julien Cristau <jcristau@debian.org> Reviewed-by: Adam Jackson <ajax@redhat.com>
Diffstat (limited to 'xkb')
0 files changed, 0 insertions, 0 deletions