summaryrefslogtreecommitdiff
path: root/pseudoramiX
diff options
context:
space:
mode:
authorNathan Kidd <nkidd@opentext.com>2015-01-09 09:57:23 -0500
committerAdam Jackson <ajax@redhat.com>2017-10-12 12:25:02 -0400
commitc206f36a4b6ecf2555ab2291c349ab7d7d0b02f5 (patch)
tree897692571963c316a878fe68c0c922b4dcc7351b /pseudoramiX
parente751722a7b0c5b595794e60b054ade0b3f6cdb4d (diff)
Unvalidated lengths
v2: Add overflow check and remove unnecessary check (Julien Cristau) This addresses: CVE-2017-12184 in XINERAMA CVE-2017-12185 in MIT-SCREEN-SAVER CVE-2017-12186 in X-Resource CVE-2017-12187 in RENDER Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com> Reviewed-by: Julien Cristau <jcristau@debian.org> Signed-off-by: Nathan Kidd <nkidd@opentext.com> Signed-off-by: Julien Cristau <jcristau@debian.org> (cherry picked from commit cad5a1050b7184d828aef9c1dd151c3ab649d37e)
Diffstat (limited to 'pseudoramiX')
-rw-r--r--pseudoramiX/pseudoramiX.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/pseudoramiX/pseudoramiX.c b/pseudoramiX/pseudoramiX.c
index d8b259341..95f6e10c8 100644
--- a/pseudoramiX/pseudoramiX.c
+++ b/pseudoramiX/pseudoramiX.c
@@ -297,10 +297,11 @@ ProcPseudoramiXGetScreenSize(ClientPtr client)
TRACE;
+ REQUEST_SIZE_MATCH(xPanoramiXGetScreenSizeReq);
+
if (stuff->screen >= pseudoramiXNumScreens)
return BadMatch;
- REQUEST_SIZE_MATCH(xPanoramiXGetScreenSizeReq);
rc = dixLookupWindow(&pWin, stuff->window, client, DixGetAttrAccess);
if (rc != Success)
return rc;