diff options
| author | Adam Jackson <ajax@redhat.com> | 2015-07-29 11:30:15 -0400 |
|---|---|---|
| committer | Adam Jackson <ajax@redhat.com> | 2015-09-17 09:43:50 -0400 |
| commit | dfa8b37cfb2589f2474f6fcc755dde77bfdd6fed (patch) | |
| tree | 803ae512231e035d330bc50aaf8676313f2bedab | |
| parent | 75ee874e432d959a70fbc2c9208d20dbfa5cbc5f (diff) | |
glxproxy: Fix an obvious thinko in QueryExtensionsString
gcc 5.1 throws a rather amusing warning here:
glxcmdsswap.c: In function ‘__glXSwapQueryExtensionsString’:
glxcmdsswap.c:439:1: warning: function might be candidate for attribute
‘noreturn’ [-Wsuggest-attribute=noreturn]
__glXSwapQueryExtensionsString(__GLXclientState * cl, GLbyte * pc)
This is entirely accurate, albeit curiously phrased: swapping some bits
hanging off the end of a null pointer will make Xdmx crash, so from the
perspective of code generation the function will indeed not return.
Reviewed-by: Keith Packard <keithp@keithp.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>
| -rw-r--r-- | hw/dmx/glxProxy/glxcmdsswap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/dmx/glxProxy/glxcmdsswap.c b/hw/dmx/glxProxy/glxcmdsswap.c index 600a6e1cb..5b1722d57 100644 --- a/hw/dmx/glxProxy/glxcmdsswap.c +++ b/hw/dmx/glxProxy/glxcmdsswap.c @@ -438,7 +438,7 @@ __glXSwapUseXFont(__GLXclientState * cl, GLbyte * pc) int __glXSwapQueryExtensionsString(__GLXclientState * cl, GLbyte * pc) { - xGLXQueryExtensionsStringReq *req = NULL; + xGLXQueryExtensionsStringReq *req = (xGLXQueryExtensionsStringReq *) pc; __GLX_DECLARE_SWAP_VARIABLES; |