diff options
| author | Tim-Philipp Müller <tim@centricular.net> | 2013-01-19 13:27:48 +0000 |
|---|---|---|
| committer | Tim-Philipp Müller <tim.muller@collabora.co.uk> | 2013-01-23 10:37:21 +0000 |
| commit | 09d192fb8c8537893d9baedc86ce561b2dce9d29 (patch) | |
| tree | 6faa77a5278b6816a4792654183d5f419a767bed | |
| parent | b38db5f538b76cf2f0be52ecff8e26702a0ea23c (diff) | |
pulsesink: don't error out if pa_stream_proplist_update() with new tags fails
Shouldn't really happen these days, but if it does, it's not really
a problem either.
https://bugzilla.gnome.org/show_bug.cgi?id=656068
| -rw-r--r-- | ext/pulse/pulsesink.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c index 249460e68..4a027104e 100644 --- a/ext/pulse/pulsesink.c +++ b/ext/pulse/pulsesink.c @@ -2700,11 +2700,12 @@ gst_pulsesink_change_props (GstPulseSink * psink, GstTagList * l) if (pbuf == NULL || pbuf->stream == NULL) goto no_buffer; + /* We're not interested if this operation failed or not */ if (!(o = pa_stream_proplist_update (pbuf->stream, PA_UPDATE_REPLACE, - pl, NULL, NULL))) - goto update_failed; + pl, NULL, NULL))) { + GST_DEBUG_OBJECT (psink, "pa_stream_proplist_update() failed"); + } - /* We're not interested if this operation failed or not */ unlock: if (o) @@ -2725,13 +2726,6 @@ no_buffer: GST_DEBUG_OBJECT (psink, "we have no ringbuffer"); goto unlock; } -update_failed: - { - GST_ELEMENT_ERROR (psink, RESOURCE, FAILED, - ("pa_stream_proplist_update() failed: %s", - pa_strerror (pa_context_errno (pbuf->context))), (NULL)); - goto unlock; - } } static void |