From 5d658bfdb4ca797104f3ad9a88dae86bee0ac77a Mon Sep 17 00:00:00 2001 From: Uwe Kleine-König Date: Mon, 23 Sep 2013 18:00:20 +0200 Subject: remoteproc/davinci: drop needless devm_clk_put MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment above disable_irq says that it is needed to ensure that the "devm subsystem might end up releasing things before freeing the irq, thus allowing an interrupt to sneak in while the device is being removed." disable_irq is enough for this purpose and there is no need to manually free the reference to the clock. Cc: Robert Tivy Signed-off-by: Uwe Kleine-König [moved the Cc line into the commit message] Signed-off-by: Ohad Ben-Cohen --- drivers/remoteproc/da8xx_remoteproc.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'drivers/remoteproc') diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c index 129f7b997866..b91cd3086fb7 100644 --- a/drivers/remoteproc/da8xx_remoteproc.c +++ b/drivers/remoteproc/da8xx_remoteproc.c @@ -301,8 +301,6 @@ static int da8xx_rproc_remove(struct platform_device *pdev) */ disable_irq(drproc->irq); - devm_clk_put(dev, drproc->dsp_clk); - rproc_del(rproc); rproc_put(rproc); -- cgit v1.2.3