From 7392fd54378f7517ddb049dfa8725c4999669310 Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Fri, 6 Feb 2015 12:55:06 +0100 Subject: Remove MSVC++ strncpy/strcat fallbacks We currently have macros silently replacing use of strncpy/strcat with strcpy_s/strcat_s when using MSVC++. However, these macros can have unexpected effects as they use sizeof to find out the maximum size of the destination string. This is a very significant behaviour from strncpy/strcat, which can lead to subtle bugs as the behaviour is different between mingw and MSVC++. Now that we have our implementation of strcpy_s/strcat_s, we don't need these #defines. --- vdagent/file_xfer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'vdagent') diff --git a/vdagent/file_xfer.h b/vdagent/file_xfer.h index 7f756e3..7ac911e 100644 --- a/vdagent/file_xfer.h +++ b/vdagent/file_xfer.h @@ -27,7 +27,7 @@ typedef struct ALIGN_VC FileXferTask { // FIXME: should raise an error if name is too long.. // currently the only user is FileXfer::handle_start // which verifies that strlen(_name) < MAX_PATH - vdagent_strncpy_s(name, sizeof(name), _name); + vdagent_strcpy_s(name, sizeof(name), _name); } HANDLE handle; uint64_t size; -- cgit v1.2.3