Age | Commit message (Collapse) | Author | Files | Lines |
|
https://bugzilla.gnome.org/show_bug.cgi?id=625897
|
|
Stop using the 'enabled' key for the http proxy as it's not meant to
be used - see bug 648237.
Only read and use the proxy settings in one place. Add missing proxy
properties to SjMetadata and bind them in SjMetadataGetter. Bind the
properties with G_SETTINGS_BIND_GET_NO_CHANGES to avoid problems when
the settings are updated from a different thread.
The change to gsettings removes the ability to set a local musicbrainz
server. The support for this was half-hearted as it was only possible
to set a custom hostname, not a custom port.
https://bugzilla.gnome.org/show_bug.cgi?id=625897
|
|
The gsettings documentation recommends that the two names should
match. As changing an existing dbus name in probably a bad idea change
the schema name instead.
https://bugzilla.gnome.org/show_bug.cgi?id=625897
|
|
If the file pattern is empty then all the ripped tracks are written to
".ogg". If the path pattern is empty then all ripped music ends up in
the same directory. The default patterns were removed in commit
49b5a5785 as they were not synchronized between sj-main.c and
sj-prefs.c. Adding two utility functions solves this problem.
https://bugzilla.gnome.org/show_bug.cgi?id=625897
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=625897
|
|
Try and improve readability of the descriptions for format specifiers
and add missing composer format specifiers. Reword some other
descriptions as well.
https://bugzilla.gnome.org/show_bug.cgi?id=625897
|
|
Be more specific about the filetype of the gsettings schema file.
https://bugzilla.gnome.org/show_bug.cgi?id=625897
|
|
Part of the fixes for bgo #625897.
|
|
Part of the fixes for bgo #625897.
|
|
Including reviews/contributions from Gert Michael Kulyk and Phillip Wood.
https://bugzilla.gnome.org/show_bug.cgi?id=625897
|
|
Set expand to true on the scroll view and tree view so they fill the
dialog box.
https://bugzilla.gnome.org/show_bug.cgi?id=721885
|
|
This is based on rhythmbox commit 7102535 by Jonathan Matthew.
https://bugzilla.gnome.org/show_bug.cgi?id=679478
|
|
|
|
|
|
|
|
|
|
|
|
Use Help/About/Quit instead of About Sound Juicer/Help/Quit
https://bugzilla.gnome.org/show_bug.cgi?id=720149
|
|
GCC now complains about function prototypes without parameters. This
fixes those warnings.
https://bugzilla.gnome.org/show_bug.cgi?id=698599
|
|
|
|
read_sparse is available starting with libdiscid 0.5.0.
Using read() started to be slow with 0.3.1, since
now ISRCs and the MCN are read by default.
We now only read what we need.
https://bugzilla.gnome.org/show_bug.cgi?id=697899
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
The search doesn't work as it's not set up and doesn't serve any
useful purpose so disable it.
https://bugzilla.gnome.org/show_bug.cgi?id=706394
|
|
If the translation of 'Stop' was longer than that of 'Extract',
'Pause' and 'Play' then the extract button would change size when it
was clicked. Fix by adding fake buttons with both labels to a size
group as for the play and select all buttons.
https://bugzilla.gnome.org/show_bug.cgi?id=706188
|
|
This removes the arrow on the 'Continue' button in the multiple album
dialog partly to conform with the recommendation that buttons just
have a label describing their action and partly to avoid having to
deal with the RTL variant of the icon. The Alt+N accelerator on
'Cancel' in the infobar is non standard but avoids a clash with the
album composer entry. Alt+P for Pause is non standard but avoids a
clash with the album artist entry and gives a consistent accelerator
for Play/Pause. The disc number entry was missing an accelerator so it
is assigned Alt+D.
https://bugzilla.gnome.org/show_bug.cgi?id=705131
|
|
This works around GTK bug #702423 which stops the playback icon showing
on GTK 3.8 & later. This is also a small first step towards removing
deprecated stock items.
https://bugzilla.gnome.org/show_bug.cgi?id=705131
|
|
|
|
|
|
|
|
|
|
|
|
|
|
In the transition from glade to gtkbuilder the adjustment for
seek_scale went AWOL. As a result that slider didn't move in playback
and trying to seek with the mouse rewound the track to the start
because the range for the scale wasn't properly initialized. This fix
adds the adjustment back into the UI file, updates the scale widget to
GtkScale and fixes seeking with the keyboard as well.
N.B. The keyboard fix bumps the minimum GTK version requirement to 3.2
https://bugzilla.gnome.org/show_bug.cgi?id=637867
|
|
Left to its own devices the multiple releases dialog's default size is
too small to display all the information for two albums without
scrolling.
https://bugzilla.gnome.org/show_bug.cgi?id=674926
|
|
To display the entries in the multiple release dialog in a consistent
manner they should be sorted.
https://bugzilla.gnome.org/show_bug.cgi?id=674926
|
|
With just the album title and artist, it is sometimes impossible to
tell the difference between all the releases listed. Adding the
recording label, year and country will help to distinguish between
different versions of the same album.
https://bugzilla.gnome.org/show_bug.cgi?id=674926
|
|
Enables disambiguation between the same album released as a single or
part of a box set. Only shown when there is more than on disc in a
set.
https://bugzilla.gnome.org/show_bug.cgi?id=674926
|
|
At the moment the user inevitably has to scroll to the right to see
the artist when choosing between multiple releases. As there are only
ever a handful of releases to choose between it would be better to
display the artist below album title so all the information is visible
at once in a single column. This will be especially true once we add
the release label, year and country as well. Make the album title bold
and the artist name italic to visually differentiate between them.
https://bugzilla.gnome.org/show_bug.cgi?id=674926
|
|
To display the recording label, year and country on one line we need a
function to combine them into a string.
https://bugzilla.gnome.org/show_bug.cgi?id=674926
|