Age | Commit message (Collapse) | Author | Files | Lines |
|
The suffix should be something like gabble-0.15.4, to yield
libwocky-gabble-0.15.4.so ("the Wocky from Gabble 0.15.4").
|
|
|
|
It's never been considered valid, and since GLib 2.31.something
it issues a warning, which breaks the Gabble regression tests.
We're still using 0 as the error code because WockyTLSError has
apparently never actually defined what its error enum is, and in its
existing uses in the OpenSSL backend it's an OpenSSL error code,
which is obviously not applicable here.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=46379
Reviewed-by: Vivek Dasmohapatra <vivek@collabora.co.uk>
|
|
For better or worse, we expose these to applications, so we should
namespace them. (This isn't purely theoretical: the names clash with the
same ones in Gibber within Salut.)
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=27489
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
As Simon mentions on
<https://bugs.freedesktop.org/show_bug.cgi?id=27489#c1> and comments in
that file specify, some bits of wocky-pubsub-node-protected.h are
intended for applications, and other bits are internal to Wocky. So
let's split the later bits into a new header,
wocky-pubsub-node-internal.h, which is not included by wocky.h and has
internal-only header guards.
|
|
|
|
If wocky-debug.h is to contain API for applications, that API should
probably always be defined.
|
|
Gabble uses a couple of bits of this API to turn on a little bit of
Wocky's debug output for the purposes of the D-Bus debugging interface,
so making debug.h internal-only is not going to fly. However, most of it
really is internal-only.
|
|
|
|
I think it's reasonable to assume that importing the header which gives
you WockyXmppError should also give you WOCKY_TYPE_XMPP_ERROR.
|
|
|
|
This function doesn't exist.
|
|
Apparently the latter stopped being recognized by gtk-doc at some point.
:(
|
|
|
|
Asserting that wocky_porter_close_finish() returns TRUE is fine and all,
but when it fails you get no information about why it failed. By passing
a non-NULL GError ** parameter and asserting on that error first, we get
the details of what actually happened immediately.
|
|
test_close_porter() assumes test->sched_in has not been started, and
calls wocky_xmpp_connection_recv_stanza_async() on test->in; the
callback assumes that the call has failed with an error indicating that
the stream has been closed. This would be fine if the test was sure
there were no stanzas in the queue in test->in, but since my change to
make WockyC2SPorter send back an error in response to unhandled IQs,
this assumption is no longer true: there are error replies sitting
around waiting to be handled.
So this patch just makes this test turn both porters on and then use
test_close_both_porters().
|
|
XMPP Core requires that we reply to all IQs we receive. If no handler
claims responsibility for an incoming IQ, the porter should send back a
<service-unavailable/> error. (Currently, Gabble does this.)
https://bugs.freedesktop.org/show_bug.cgi?id=34975
|
|
|
|
This doesn't seem to be used for anything, and creates an artificial
dependency on gcrypt, which GNUTLS 3 no longer uses.
Verified to pass tests on Debian's gnutls26 2.12.16-1 package, but
insufficient to make tests pass on gnutls28 3.0.12-1.
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=43992
Bug-Debian: http://bugs.debian.org/638420
|
|
We don't include stdlib.h (except accidentally, via gcrypt.h), which we
should if we're going to use its functions. In both cases GLib has a
portable version, and our coding style is generally to prefer the GLib
versions of things, so let's use those.
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=43992
|
|
|
|
|
|
|
|
|
|
In windows socket API setsockopt takes a const char * as the fourth
parameter, while on Linux it takes a void * so we cast to
const char * which will work under both the platforms. This patch
also move flags veriable in client_connected to the unix part of the
ifdef, to remove warnings which shows up with mingw32.
|
|
gnutls_transport_set_push_function expects a function of
ssize_t (*gnutls_push_func)(gnutls_transport_ptr_t, const void*, size_t);
and in mingw32 gsize and gssize doesn't expend to size_t or ssize_t.
this results in mingw32 builds fail due to the warning.
https://bugs.freedesktop.org/show_bug.cgi?id=45272
|
|
_stat shadows a global variable defined in mingw32 so this patch
renames it to peer_cert_status in wocky_tls_session_verify_peer
https://bugs.freedesktop.org/show_bug.cgi?id=45272
|
|
|
|
These changes enables us to cross-compile wocky for windows with mingw32
|
|
They are needed for wocky_caps_hash_compute_from_lists().
https://bugs.freedesktop.org/show_bug.cgi?id=43891
|
|
|
|
Code that we don't build won't build.
|
|
|
|
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=43584
|
|
field->raw_value_contents was not initialized when the field was not coming
from a WockyNode. It leads to a segfault in add_field_to_node_using_default().
The following code was triggering the crash:
form = g_object_new (WOCKY_TYPE_DATA_FORM, NULL);
wocky_data_form_set_string (form, "field", "value", TRUE);
wocky_data_form_add_to_node (form, ...);
This patch initializes field->raw_value_contents when the WockyNode is created
through data_form_set_value().
The unit tests are updated to check this.
https://bugs.freedesktop.org/show_bug.cgi?id=43584
|
|
|
|
|
|
|
|
g_utf8_validate
In some cases valid utf-8, but for non-character codepoints gets send
through xmpp. Other parts of the system can get confused by those (e.g.
D-Bus doesn't allow them in strings). So we need to ensure that they get
filtered out as soon as possible.
There are two obvious places to do this, either in the XmppReader or
the Nodes. Doing it in the nodes has the advantage of ensuring
consistency for all data going into the Node, not just what was read
from xmpp directly. Furthermore the Node api calls already copy the
strings internally, which is a good place place to do the conversions if
needed.
|
|
https://bugs.freedesktop.org/show_bug.cgi?id=42509
|
|
|
|
This makes it easier to verify that a node has the name and namespace
you expect.
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|
|
|
This is useful in writing an XMPP console for Gabble.
|
|
For really specialised cases, like an XML console in Gabble, you want to
be able to match stanzas of any type. The docs claim you can do this,
but they lie.
I could be convinced that the correct way to do this is to add a fourth
method, wocky_porter_register_handler_for_any_stanza (), and that the
server/anyone/from variants are unnecessary. Thoughts?
https://bugs.freedesktop.org/show_bug.cgi?id=38577
|
|
|
|
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
|
|
|