Age | Commit message (Collapse) | Author | Files | Lines |
|
We no longer want to delete the directories containing old filenames
(all old directories that we currently support are owned by Telepathy-0
and should not be deleted).
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=70991
|
|
We're not going to delete Telepathy-0 account data in Telepathy-1.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=70991
|
|
Conflicts:
src/mcd-storage.c
|
|
Conflicts:
configure.ac
src/mcd-account-connection.c
src/mcd-account-manager.c
src/mcd-account.c
src/mcd-account.h
tools/glib-client-gen.py
tools/glib-client-marshaller-gen.py
tools/glib-ginterface-gen.py
tools/glib-gtypes-generator.py
tools/libglibcodegen.py
tools/libtpcodegen.py
xml/all.xml
xml/telepathy-types.xml
|
|
Modifications:
* stub out 5-12 and 5-14 tests
* replace Valid, Invalid with Usable, Unusable in new tests
* replace AccountPropertiesChanged with PropertiesChanged in new tests
* use telepathy-1 paths in new tests
Conflicts:
configure.ac
src/mcd-account-manager.c
src/mcd-storage.h
tests/twisted/Makefile.am
tests/twisted/account-manager/avatar-refresh.py
tests/twisted/account-storage/default-keyring-storage.py
util/mc-tool.c
|
|
|
|
|
|
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
[also depend on new tp-glib for
tp_connection_manager_param_dup_variant_type -smcv]
|
|
It is not valid to call _mcd_account_connection_begin() unless the
account has a TpProtocol; in particular, if the account is "valid",
then we know it does have a TpProtocol.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Now that I've deleted ExternalAccountStorage support, we have two
uses for this function:
* get the parameters to be passed to RequestConnection
* get the parameters for our own D-Bus API (PropertiesChanged,
GetAll, etc.)
For the former, we should know the types already, because we should
already have a concrete CM/protocol in mind by the time we get here.
For the latter, ideally we shouldn't need the CM's types at all: if
the backend is storing parameters with types, it's arguably more
correct for Parameters to contain what the user stored, even if that
isn't an exact match for what the CM wants.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
There isn't actually anything in these functions that needs to be async.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
There's hardly anything there any more anyway.
Take the opportunity to replace _mcd_account_set_connection_context
and _mcd_account_get_connection_context with simple access to the
priv struct.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
We never call this function without a TpConnectionManagerParam readily
available - which is just as well, because it looks as though it would
crash if mcd_manager_get_protocol_param() failed.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71093
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69600
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33485
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=44512
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69600
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
|
|
This will make the account more self-contained.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
|
|
We're going to need this soon, in order to advise plugins how best
to unescape the value. The result is still a GValue, for now.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
|
|
This means we don't need to commit separately after each deletion,
and means account plugins don't have to have the concept of flagging
an account for "delete this later" - much rejoicing.
It also has the incidental benefit that we no longer use the C++
reserved word 'delete' in a header file.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
|
|
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
|
|
We still don't get here if disposed early, though.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27727
|
|
We now depend on SASLAuthentication for handling secret, and MC
does not have gnome-keyring anymore.
[Adjusted to apply before other storage API changes -smcv]
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71384
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
|
|
Conflicts:
src/connectivity-monitor.c
src/mcd-connection.c
tests/twisted/account-storage/libaccounts-sso-storage.py
|
|
This reverts commit ae64063c953840f99b1204a222fabf5aa7a37b69.
|
|
This reverts commit 6ebcb0f048fcf0107c6d7deb99a7f4717467561a.
|
|
If it is the storage plugin informing MC that the account has been
deleted, we can assume that the storage will already take care of
removing all information.
|
|
We now depend on SASLAuthentication for handling secret, and MC
does not have gnome-keyring anymore.
|
|
I assumed that if TP_STORAGE_RESTRICTION_FLAG_CANNOT_SET_ENABLED
or TP_STORAGE_RESTRICTION_FLAG_CANNOT_SET_PRESENCE, then a hypothetical
CANNOT_DELETE flag would also have been present.
|
|
I used CANNOT_SET_PRESENCE to control access to ConnectAutomatically
as well as the obvious AutomaticPresence and RequestedPresence, because
RequestedPresence is not under the storage plugin's control - it is
derived from ConnectAutomatically and AutomaticPresence at runtime.
Use MCD_DBUS_PROP_SET_FLAG_ALREADY_IN_STORAGE as a way to bypass the
storage restriction flags, so that storage plugins themselves can
alter enabledness etc. even if they don't allow MC to change it.
The regression test for this initially failed, because toggled_cb()
did not pass that flag to the McdAccount: fix that too.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71390
|
|
|
|
|
|
Tests pass with telepathy-glib 0.99.2.
Conflicts:
src/Makefile.am
src/mcd-account-manager-priv.h
src/mcd-account-manager.c
src/mcd-account-priv.h
src/mcd-account.c
src/mcd.xml
tests/twisted/account-manager/hidden.py
tests/twisted/constants.py
tests/twisted/mctest.py
xml/Account_Interface_Hidden1.xml
xml/Account_Manager_Interface_Hidden1.xml
xml/Makefile.am
xml/nmc5.xml
|
|
They haven't been undrafted since they were added 2.5 years ago, and
Will described them as "a bit sketchy" back then... which doesn't
seem particularly compatible with consolidating and simplifying
for 1.0. It's not clear to me that Telepathy is particularly
appropriate for "non-user-facing" accounts.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33101
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
I was never sure about the design, and the supporting code was removed
when I refactored connectivity for 5.16. If it's needed in future,
we can bring it back, hopefully with a simpler design (fd.o #24896).
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69600
|
|
In a future version we should make telepathy-glib generate this
interface, but this will do for now.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54879
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54879
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54879
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Based on a patch by Jonny Lamb.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54879
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Sadly, contact attributes aren't enough to distinguish between
"this protocol doesn't store avatars and you haven't re-sent your
avatar since you last connected", "this protocol stores avatars but
the CM hasn't checked for your current avatar yet", and "this protocol
stores avatars, but there is no avatar on the server for you".
GetKnownAvatarTokens specifically excludes the middle option (blocking
on a server round-trip if it needs to), and uses "avatar token missing"
for the first and "avatar token empty" for the last.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69885
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
If the account is disconnecting, we might get the callback for
upgrading after we've already NULLed out self->priv->self_contact.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
In particular, mcd-account-manager-default could crash when migrating
an account, since it would dereference arbitrary stack contents
as a pointer-to-string.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Now that McdAccount has a TpContact for the self-contact, this is
really easy.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68905
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68758
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|