Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54780
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
[deleted a stray line from a comment as per wjt's review -smcv]
Conflicts:
src/mcd-account.c
|
|
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54873
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Conflicts:
tests/twisted/account-manager/avatar.py
|
|
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54872
[amended to add GLib 2.32 dependency -smcv]
Conflicts:
src/mcd-account.c
|
|
|
|
|
|
In particular, this propagates the error from RequestConnection failing
correctly, so add a regression test for that.
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39334
|
|
Nothing listens to it.
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39334
|
|
|
|
|
|
a5a5d850 started using these functions, which were introduced in
telepathy-glib 0.20.0.
|
|
Like telepathy-glib does already.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=57165
Reviewed-By: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
ConnMan 0.79 removed the GetState method and StateChanged signal.
Use the GetProperties method and PropertyChanged signals as their
replacements.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=56600
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
g_type_init() has been deprecated in GLib master. By including those files I
can build without raising a deprecation error as we define
GLIB_VERSION_MIN_REQUIRED to 2.30.
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55668
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
The NetworkError connection status maps to several TpErrors,
so first check the error codes to decide whether we should
automatically reconnect, and fallback to the connection
status if we don't recognize the error.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37844
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
|
|
It can be retrieved from the McdAccount.
|
|
This is highly theoretical, but in principle it could happen.
|
|
This is consistent with what we do when we first connect, and ensures
that we always have some sort of nickname.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
IRC has plenty of oddities, but the one we're interested in here
is that your nickname and your unique identifier are inextricably linked.
|
|
|
|
|
|
Mutable defaults for arguments are dangerous. If we call
enable_fakecm_account twice with default arguments, when we alter
expect_before_connect/expect_after_connect, we are actually altering
the default! Python doesn't construct a new empty list for us every
time. The C equivalent would be a static GPtrArray * or something.
|
|
We still allow the nickname to be set to the normalized name by
user action later, because in that case, the intention is unambiguous:
the user really does want their nickname to take that value.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39381
|
|
As well as being implemented in a more streamlined way (using the
self-contact instead of calling D-Bus methods directly), this reduces
the circular dependencies between McdConnection and McdAccount.
|
|
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
This means we can avoid the deprecated
tp_channel_borrow_immutable_properties().
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
This avoids the deprecated tp_channel_new_from_properties(). It has the
same disadvantages as that function, but is a bit more obvious about it.
Also comment how to change things at the next ABI break.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
dbus_g_connection_register_g_object isn't deprecated, but it's more code.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
MC's reinvention was potentially better if the channel might lack the
Requested property... but that property has been mandatory for years,
so CMs that haven't caught up can just deal with it.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
This requires telepathy-glib 0.19.9, so depend on it.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
tp_account_manager_get_valid_accounts has the confusing
(transfer container) transfer-mode, and is deprecated in telepathy-glib
0.19.9.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Tested with telepathy-glib 0.20.0.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Tested with telepathy-glib 0.20.0.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
Originally two patches for 'next' by Jonny Lamb.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|