1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
|
#include "config.h"
#include <dbus/dbus.h>
#include <dbus/dbus-glib-lowlevel.h>
#include <telepathy-glib/cli-misc.h>
#include <telepathy-glib/dbus.h>
#include <telepathy-glib/debug.h>
#include <telepathy-glib/errors.h>
#include <telepathy-glib/interfaces.h>
#include <telepathy-glib/intset.h>
#include <telepathy-glib/proxy-subclass.h> /* for _invalidated etc. */
#include <telepathy-glib/svc-generic.h>
#include <telepathy-glib/util.h>
#include "tests/lib/myassert.h"
#include "tests/lib/simple-channel-dispatcher.h"
#include "tests/lib/stub-object.h"
#include "tests/lib/util.h"
/* just for convenience, since it's used a lot */
#define PTR(ui) GUINT_TO_POINTER(ui)
/* state tracking */
static TpIntset *caught_signal;
static TpIntset *freed_user_data;
enum {
TEST_A,
TEST_B,
TEST_C,
TEST_D,
TEST_E,
TEST_F,
TEST_G,
TEST_H,
TEST_Z = 25,
N_PROXIES
};
typedef struct {
TpDBusDaemon *dbus_daemon;
TpProxy *proxies[N_PROXIES];
GObject *cd_service;
DBusConnection *private_libdbus;
DBusGConnection *private_dbusglib;
TpDBusDaemon *private_dbus_daemon;
} Fixture;
static Fixture *f;
static void
h_stub_destroyed (gpointer data,
GObject *stub)
{
TpProxySignalConnection **p = data;
tp_proxy_signal_connection_disconnect (*p);
}
static void
destroy_user_data (gpointer user_data)
{
guint which = GPOINTER_TO_UINT (user_data);
g_message ("User data %c destroyed", 'A' + which);
MYASSERT (!tp_intset_is_member (freed_user_data, which), "");
tp_intset_add (freed_user_data, which);
}
static void
unwanted_signal_cb (TpProxy *proxy,
const gchar *iface,
GHashTable *changed,
const gchar **invalidated,
gpointer user_data,
GObject *weak_object)
{
g_error ("unwanted_signal_cb called - a signal connection which should have "
"failed has succeeded. Args: proxy=%p user_data=%p", proxy, user_data);
}
static void
signal_cb (TpProxy *proxy,
const gchar *iface,
GHashTable *changed,
const gchar **invalidated,
gpointer user_data,
GObject *weak_object)
{
guint which = GPOINTER_TO_UINT (user_data);
TpProxy *want_proxy = NULL;
GObject *want_object = NULL;
g_message ("Caught signal with proxy #%d '%c' according to "
"user_data", which, 'a' + which);
g_message ("Proxy is %p, weak object is %p", proxy,
weak_object);
tp_intset_add (caught_signal, which);
want_proxy = f->proxies[which];
switch (which)
{
case TEST_A:
want_object = (GObject *) f->proxies[TEST_Z];
break;
case TEST_Z:
want_object = (GObject *) f->proxies[TEST_A];
break;
default:
g_error ("%c (%p) got the signal, which shouldn't have happened",
'a' + which, proxy);
}
g_message ("Expecting proxy %p, weak object %p", want_proxy, want_object);
MYASSERT (proxy == want_proxy, ": %p != %p", proxy, want_proxy);
MYASSERT (weak_object == want_object, ": %p != %p", weak_object,
want_object);
}
static void
set_freed (gpointer user_data)
{
gboolean *boolptr = user_data;
MYASSERT (*boolptr == FALSE, "");
*boolptr = TRUE;
}
static void
setup (void)
{
f->dbus_daemon = tp_tests_dbus_daemon_dup_or_die ();
/* Any random object with an interface: what matters is that it can
* accept a method call and emit a signal. We use the Properties
* interface here. */
f->cd_service = tp_tests_object_new_static_class (
TP_TESTS_TYPE_SIMPLE_CHANNEL_DISPATCHER,
NULL);
tp_dbus_daemon_register_object (f->dbus_daemon, "/", f->cd_service);
f->private_libdbus = dbus_bus_get_private (DBUS_BUS_STARTER, NULL);
g_assert (f->private_libdbus != NULL);
dbus_connection_setup_with_g_main (f->private_libdbus, NULL);
dbus_connection_set_exit_on_disconnect (f->private_libdbus, FALSE);
f->private_dbusglib = dbus_connection_get_g_connection (
f->private_libdbus);
dbus_g_connection_ref (f->private_dbusglib);
f->private_dbus_daemon = tp_dbus_daemon_new (f->private_dbusglib);
g_assert (f->private_dbus_daemon != NULL);
}
static void
drop_private_connection (void)
{
dbus_g_connection_unref (f->private_dbusglib);
f->private_dbusglib = NULL;
dbus_connection_close (f->private_libdbus);
dbus_connection_unref (f->private_libdbus);
f->private_libdbus = NULL;
}
static void
teardown (void)
{
tp_tests_assert_last_unref (&f->cd_service);
tp_tests_assert_last_unref (&f->dbus_daemon);
tp_tests_assert_last_unref (&f->private_dbus_daemon);
}
static TpProxy *
new_proxy (int which)
{
TpDBusDaemon *local_dbus_daemon;
if (which == TEST_F)
local_dbus_daemon = f->private_dbus_daemon;
else
local_dbus_daemon = f->dbus_daemon;
return tp_tests_object_new_static_class (TP_TYPE_PROXY,
"dbus-daemon", local_dbus_daemon,
"bus-name", tp_dbus_daemon_get_unique_name (f->dbus_daemon),
"object-path", "/",
NULL);
}
int
main (int argc,
char **argv)
{
Fixture fixture = { NULL };
GObject *stub;
GError *error_out = NULL;
GError err = { TP_ERROR, TP_ERROR_INVALID_ARGUMENT, "Because I said so" };
TpProxySignalConnection *sc;
gboolean freed = FALSE;
GHashTable *empty_asv;
int i;
tp_tests_abort_after (10);
tp_debug_set_flags ("all");
freed_user_data = tp_intset_sized_new (N_PROXIES);
caught_signal = tp_intset_sized_new (N_PROXIES);
/* it's on the stack, but it's valid until we leave main(), which will
* do for now... one day this test should use GTest, but this might
* not be that day */
f = &fixture;
setup ();
g_message ("Creating proxies");
for (i = TEST_A; i <= TEST_H; i++)
{
f->proxies[i] = new_proxy (i);
g_message ("%c=%p", 'a' + i, f->proxies[i]);
}
f->proxies[TEST_Z] = new_proxy (TEST_Z);
g_message ("z=%p", f->proxies[TEST_Z]);
/* a survives */
g_message ("Connecting signal to a");
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_A],
signal_cb, PTR (TEST_A),
destroy_user_data, (GObject *) f->proxies[TEST_Z], &error_out);
g_assert_no_error (error_out);
/* b gets its signal connection cancelled because stub is
* destroyed */
stub = tp_tests_object_new_static_class (tp_tests_stub_object_get_type (),
NULL);
g_message ("Connecting signal to b");
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_B],
signal_cb, PTR (TEST_B),
destroy_user_data, stub, &error_out);
g_assert_no_error (error_out);
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_B), "");
tp_tests_assert_last_unref (&stub);
/* c gets its signal connection cancelled because it's explicitly
* invalidated */
g_message ("Connecting signal to c");
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_C],
signal_cb, PTR (TEST_C),
destroy_user_data, NULL, &error_out);
g_assert_no_error (error_out);
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_C), "");
g_message ("Forcibly invalidating c");
tp_proxy_invalidate ((TpProxy *) f->proxies[TEST_C], &err);
/* assert that connecting to a signal on an invalid proxy fails */
freed = FALSE;
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_C],
unwanted_signal_cb, &freed,
set_freed, NULL, &error_out);
MYASSERT (freed, "");
MYASSERT (error_out != NULL, "");
g_message ("%d: %d: %s", error_out->domain, error_out->code,
error_out->message);
MYASSERT (error_out->code == err.code, "%d != %d", error_out->code,
err.code);
g_error_free (error_out);
error_out = NULL;
/* d gets its signal connection cancelled because it's
* implicitly invalidated by being destroyed */
g_message ("Connecting signal to d");
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_D],
signal_cb, PTR (TEST_D),
destroy_user_data, NULL, &error_out);
g_assert_no_error (error_out);
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_D), "");
g_message ("Destroying d");
tp_tests_assert_last_unref (&f->proxies[TEST_D]);
/* e gets its signal connection cancelled explicitly */
g_message ("Connecting signal to e");
sc = tp_cli_dbus_properties_connect_to_properties_changed (
f->proxies[TEST_E], signal_cb, PTR (TEST_E),
destroy_user_data, NULL, &error_out);
g_assert_no_error (error_out);
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_E), "");
g_message ("Disconnecting signal from e");
tp_proxy_signal_connection_disconnect (sc);
/* f gets its signal connection cancelled because it's implicitly
* invalidated by its own connection disconnecting. */
g_message ("Connecting signal to f");
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_F],
signal_cb, PTR (TEST_F),
destroy_user_data, NULL, &error_out);
g_assert_no_error (error_out);
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_F), "");
/* g gets its signal connection cancelled because it's
* implicitly invalidated by being destroyed; unlike d, the signal
* connection weakly references the proxy. This is never necessary, but is
* an interesting corner case that should be tested. */
g_message ("Connecting signal to g");
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_G],
signal_cb, PTR (TEST_G),
destroy_user_data, (GObject *) f->proxies[TEST_G], &error_out);
g_assert_no_error (error_out);
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_G), "");
g_message ("Destroying g");
tp_tests_assert_last_unref (&f->proxies[TEST_G]);
/* h gets its signal connection cancelled because its weak object is
* destroyed, meaning there are simultaneously two reasons for it to become
* cancelled (fd.o#14750) */
stub = tp_tests_object_new_static_class (tp_tests_stub_object_get_type (),
NULL);
g_object_weak_ref (stub, h_stub_destroyed, &sc);
g_message ("Connecting signal to h");
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_H],
signal_cb, PTR (TEST_H),
destroy_user_data, stub, &error_out);
g_assert_no_error (error_out);
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_H), "");
tp_tests_assert_last_unref (&stub);
/* z survives; we assume that the signals are delivered in either
* forward or reverse order, so if both a and z have had their signal, we
* can stop the main loop */
g_message ("Connecting signal to z");
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_Z],
signal_cb, PTR (TEST_Z),
destroy_user_data, (GObject *) f->proxies[TEST_A], &error_out);
g_assert_no_error (error_out);
g_message ("Emitting signal");
empty_asv = tp_asv_new (NULL, NULL);
tp_svc_dbus_properties_emit_properties_changed (f->cd_service,
TP_IFACE_CHANNEL_DISPATCHER, empty_asv, NULL);
g_hash_table_unref (empty_asv);
g_message ("Dropping private D-Bus connection");
drop_private_connection ();
/* wait for everything to happen */
g_message ("Running main loop");
/* There's no guarantee that proxy F will detect that its socket closed
* in any particular order relative to the signals, so wait for both. */
while (!tp_intset_is_member (caught_signal, TEST_A) ||
!tp_intset_is_member (caught_signal, TEST_Z) ||
tp_proxy_get_invalidated (f->proxies[TEST_F]) == NULL)
g_main_context_iteration (NULL, TRUE);
/* assert that connecting to a signal on an invalid proxy fails */
freed = FALSE;
tp_cli_dbus_properties_connect_to_properties_changed (f->proxies[TEST_F],
unwanted_signal_cb, &freed, set_freed, NULL, &error_out);
MYASSERT (freed, "");
MYASSERT (error_out != NULL, "");
MYASSERT (error_out->code == DBUS_GERROR_NAME_HAS_NO_OWNER, "");
g_error_free (error_out);
error_out = NULL;
/* It might take a little longer to free all the user-data, because it
* happens in an idle */
while (!tp_intset_is_member (freed_user_data, TEST_B))
g_main_context_iteration (NULL, TRUE);
while (!tp_intset_is_member (freed_user_data, TEST_C))
g_main_context_iteration (NULL, TRUE);
while (!tp_intset_is_member (freed_user_data, TEST_D))
g_main_context_iteration (NULL, TRUE);
while (!tp_intset_is_member (freed_user_data, TEST_E))
g_main_context_iteration (NULL, TRUE);
while (!tp_intset_is_member (freed_user_data, TEST_F))
g_main_context_iteration (NULL, TRUE);
while (!tp_intset_is_member (freed_user_data, TEST_G))
g_main_context_iteration (NULL, TRUE);
while (!tp_intset_is_member (freed_user_data, TEST_H))
g_main_context_iteration (NULL, TRUE);
/* both A and Z are still listening for signals, so their user data is
* still held */
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_A), "");
MYASSERT (!tp_intset_is_member (freed_user_data, TEST_Z), "");
g_message ("Dereferencing remaining proxies");
tp_tests_assert_last_unref (&f->proxies[TEST_A]);
tp_tests_assert_last_unref (&f->proxies[TEST_B]);
tp_tests_assert_last_unref (&f->proxies[TEST_C]);
g_assert (f->proxies[TEST_D] == NULL);
tp_tests_assert_last_unref (&f->proxies[TEST_E]);
tp_tests_assert_last_unref (&f->proxies[TEST_F]);
g_assert (f->proxies[TEST_G] == NULL);
tp_tests_assert_last_unref (&f->proxies[TEST_H]);
tp_tests_assert_last_unref (&f->proxies[TEST_Z]);
while (!tp_intset_is_member (freed_user_data, TEST_A))
g_main_context_iteration (NULL, TRUE);
while (!tp_intset_is_member (freed_user_data, TEST_Z))
g_main_context_iteration (NULL, TRUE);
/* we should already have checked each of these at least once, but just to
* make sure we have a systematic test that all user data is freed... */
MYASSERT (tp_intset_is_member (freed_user_data, TEST_A), "");
MYASSERT (tp_intset_is_member (freed_user_data, TEST_B), "");
MYASSERT (tp_intset_is_member (freed_user_data, TEST_C), "");
MYASSERT (tp_intset_is_member (freed_user_data, TEST_D), "");
MYASSERT (tp_intset_is_member (freed_user_data, TEST_E), "");
MYASSERT (tp_intset_is_member (freed_user_data, TEST_F), "");
MYASSERT (tp_intset_is_member (freed_user_data, TEST_G), "");
MYASSERT (tp_intset_is_member (freed_user_data, TEST_H), "");
MYASSERT (tp_intset_is_member (freed_user_data, TEST_Z), "");
tp_intset_destroy (freed_user_data);
tp_intset_destroy (caught_signal);
teardown ();
return 0;
}
|