Age | Commit message (Collapse) | Author | Files | Lines |
|
Because GDBusObjectSkeleton holds a ref to all its interface skeletons
as long as the parent object exists, it's possible that they will
have been unexported but not freed.
|
|
Gabble's regression tests expect to receive PresencesChanged before
StatusChanged, and PresencesChanged is triggered by the status-changed
GObject signal.
|
|
We use gdbus-codegen's skeleton to implement Connection iface now.
[adjusted to apply on top of making it a GDBusObjectSkeleton, and
handle Interfaces accordingly -smcv]
|
|
|
|
|
|
TpBaseConnection is about to stop implementing it and use
gdbus-codegen's skeleton instead.
|
|
|
|
This means we don't need the get_interfaces_array() vfunc, because we
can inspect the GDBusObject interface to find out what our interfaces
are.
|
|
This requires some careful juggling to make it able to call methods
on the TpDBusPropertiesMixin without having to move the entire
TpDBusPropertiesMixin to the -dbus library.
|
|
from a GDBusObject
|
|
|
|
|
|
The filter callback is ran in GDBusConnection's worker thread
so we can't be sure how stuff are ordered. By delaying the
GetAll reply and re-send it from the main thread we are sure
that the SelfContactChanged signal will be sent just after it.
|
|
This reverts commit 5a3524270c6d1febeccfbf636fc59b2da48f33b6.
|
|
may-save-response is still exposed as a GObject property, because it's
construct-only, so presumably there's some expectation that it would
be set at construct-time.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77187
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77187
Reviewed-by: Xavier Claessens
|
|
remove
They are not used in Folks, Empathy, MC or the "big 5" CMs, except for one
use of dbus-status in helper code for Folks' regression tests (which will
disappear when resynced from telepathy-glib).
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77187
Reviewed-by: Xavier Claessens
|
|
tp_dbus_properties_mixin_getter_gobject_properties()
Using that tied us to having a GDBus property whose type matches the
dbus-glib type, which is API we don't want.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77187
Reviewed-by: Xavier Claessens
|
|
This used to be done so we could emulate a connection manager older
than telepathy-spec 0.19.2, but that functionality was removed in
commit 347307b7.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77187
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77191
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77190
Reviewed-by: Xavier Claessens
|
|
tp_group_mixin_get_local_pending_members_with_info() uses a dbus-glib
data type, and none of these are actually used in the five core CMs
(they all track members separately in any case).
Make them private if used in the implementation, or remove them entirely.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77190
Reviewed-by: Xavier Claessens
|
|
The timing requirements for test_change_inconveniently() are very
specific, and on my laptop, using the GDBus filter wasn't good enough
(probably because looping on g_main_context_iteration() runs a whole
iteration and cannot be stopped halfway through). I could usually
reproduce a test failure by running the telepathy-glib tests in
parallel with the telepathy-gabble tests.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Xavier Claessens
|
|
MC still needs this.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Xavier Claessens
|
|
GDBusConnection and TpSvcInterfaceSkeleton does it for us already.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Simon McVittie
|
|
We prevent TpSvcDBusProperties interface to be registered so
GDBusConnection will handle that itself using skeleton's vtable.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Simon McVittie
|
|
directly
We are about to stop exporting TpSvcDBusProperties iface so they
would be no-op.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Simon McVittie
|
|
We are about to stop exporting TpSvcDBusProperties iface so they
would be no-op.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Simon McVittie
|
|
We are about to stop exporting TpSvcDBusProperties iface so they
would be no-op.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Simon McVittie
|
|
We are about to stop exporting TpSvcDBusProperties iface so they
would be no-op.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Simon McVittie
|
|
We are about to stop exporting TpSvcDBusProperties iface so they
would be no-op.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77144
Reviewed-by: Simon McVittie
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
They have a dbus-glib type, and Empathy exclusively uses
tp_text_channel_supports_message_type() instead.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
It's still a GHashTable internally, because lots of subclasses still
rely on that.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
We're using an Entity_Type_None (nameless chatroom) channel, but
claiming in its immutable properties that it has a non-empty
target of type Contact. That means we're effectively making assertions
about whether the immutable properties we specified at the beginning,
or the result of GetAll(), will "win", which makes this test
unnecessarily brittle.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Implementing TpChannelIface meant that channel-type, handle-type
and handle had to be settable at construct-time. That is no longer
a supported thing to do: everyone should be using the immutable
properties dict.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
The implementation is really simplistic, and copies everything into
dbus-glib data types.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Also be (somewhat) cancellable, while I'm there.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
It uses the dbus-glib type system.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|
|
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=76369
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77139
Reviewed-by: Xavier Claessens
|