From 89c74b3dd86000581d15270dddbee1f6a2cade39 Mon Sep 17 00:00:00 2001
From: Sebastian Dröge <sebastian@centricular.com>
Date: Thu, 18 Aug 2016 15:48:57 +0300
Subject: playback/player: gtk: Use GQueue instead of g_list_append() or the
 prepend-reverse trick

---
 playback/player/gtk/gtk-play.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/playback/player/gtk/gtk-play.c b/playback/player/gtk/gtk-play.c
index 16afc6b..8aa6975 100644
--- a/playback/player/gtk/gtk-play.c
+++ b/playback/player/gtk/gtk-play.c
@@ -544,7 +544,7 @@ static GList *
 open_file_dialog (GtkPlay * play, gboolean multi)
 {
   int res;
-  GList *uris = NULL;
+  GQueue uris = G_QUEUE_INIT;
   GtkWidget *chooser;
   GtkWidget *parent;
 
@@ -568,7 +568,7 @@ open_file_dialog (GtkPlay * play, gboolean multi)
 
     l = gtk_file_chooser_get_uris (GTK_FILE_CHOOSER (chooser));
     while (l) {
-      uris = g_list_append (uris, l->data);
+      g_queue_push_tail (&uris, l->data);
       l = g_slist_delete_link (l, l);
     }
   }
@@ -577,7 +577,7 @@ open_file_dialog (GtkPlay * play, gboolean multi)
   if (!play)
     gtk_widget_destroy (parent);
 
-  return uris;
+  return uris.head;
 }
 
 static void
@@ -1828,16 +1828,15 @@ gtk_play_app_command_line (GApplication * application,
 
   if (uris_array) {
     gchar **p;
+    GQueue uris_builder = G_QUEUE_INIT;
 
     p = uris_array;
     while (*p) {
-      uris =
-          g_list_prepend (uris,
-          gst_uri_is_valid (*p) ?
+      g_queue_push_tail (&uris_builder, gst_uri_is_valid (*p) ?
           g_strdup (*p) : gst_filename_to_uri (*p, NULL));
       p++;
     }
-    uris = g_list_reverse (uris);
+    uris = uris_builder.head;
   } else {
     uris = open_file_dialog (NULL, TRUE);
   }
-- 
cgit v1.2.3