From dd7839641f51618aad86327bcadaf7ebcea47fa5 Mon Sep 17 00:00:00 2001 From: Daniel Vetter Date: Fri, 11 Jun 2021 18:49:16 +0200 Subject: drm/i915: Dont clear __EXEC_HAS_RELOC twice MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was added in commit c43ce12328df0770ce899feabdf9c430c54c766a Author: Maarten Lankhorst Date: Wed Aug 19 16:08:48 2020 +0200 drm/i915: Use per object locking in execbuf, v12. but even back then the caller of eb_relocate_parse() was clearing this flag already too. This is still the case, so just remove the duplicated clearing. Signed-off-by: Daniel Vetter Cc: Jon Bloomfield Cc: Chris Wilson Cc: Maarten Lankhorst Cc: Joonas Lahtinen Cc: Daniel Vetter Cc: "Thomas Hellström" Cc: Matthew Auld Cc: Lionel Landwerlin Cc: Dave Airlie Cc: Jason Ekstrand --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 7bd8df9321d0..bc6b5eec3f31 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -1954,18 +1954,7 @@ err: return err; slow: - err = eb_relocate_parse_slow(eb); - if (err) - /* - * If the user expects the execobject.offset and - * reloc.presumed_offset to be an exact match, - * as for using NO_RELOC, then we cannot update - * the execobject.offset until we have completed - * relocation. - */ - eb->args->flags &= ~__EXEC_HAS_RELOC; - - return err; + return eb_relocate_parse_slow(eb); } /* -- cgit v1.2.3