diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2023-06-27 16:42:35 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-06-27 09:31:51 -0700 |
commit | 528a08bcd820d07887edeae706df88ceb06db109 (patch) | |
tree | a2d71280b96fd21bcde0a01da7ff500da9dddafe /kernel/fail_function.c | |
parent | d9b1a5a60ac33da3a2921c41ef26b84bfdf67044 (diff) |
net: phy: mscc: fix packet loss due to RGMII delays
Two deadly typos break RX and TX traffic on the VSC8502 PHY using RGMII
if phy-mode = "rgmii-id" or "rgmii-txid", and no "tx-internal-delay-ps"
override exists. The negative error code from phy_get_internal_delay()
does not get overridden with the delay deduced from the phy-mode, and
later gets committed to hardware. Also, the rx_delay gets overridden by
what should have been the tx_delay.
Fixes: dbb050d2bfc8 ("phy: mscc: Add support for RGMII delay configuration")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Harini Katakam <harini.katakam@amd.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230627134235.3453358-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'kernel/fail_function.c')
0 files changed, 0 insertions, 0 deletions