diff options
| author | Zenghui Yu <yuzenghui@huawei.com> | 2021-09-25 11:55:07 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-09-27 13:01:20 +0100 |
| commit | c6e5e92cb29eab3e49dab444730b4ac200caaacb (patch) | |
| tree | 3f71cddcd969e3eb4c9516f2f3788dc82628b8fa /drivers/regulator | |
| parent | e458d3f39d917770cef2ed78891349362ecd3e15 (diff) | |
regulator: dummy: Use devm_regulator_register()
debugfs code complained at boot time that
debugfs: Directory 'reg-dummy-regulator-dummy' with parent 'regulator'
already present!
if we compile kernel with DEBUG_TEST_DRIVER_REMOVE. The problem is that we
don't provide .remove() method for dummy_regulator_driver, which should
invoke regulator_unregister() on device teardown to properly free things.
Though it's harmless as dummy_pdev never gets unbound in practice, let's
use devm_regulator_register() to get rid of the inconsistency.
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
Link: https://lore.kernel.org/r/20210925035507.1904-1-yuzenghui@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
| -rw-r--r-- | drivers/regulator/dummy.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/regulator/dummy.c b/drivers/regulator/dummy.c index d8059f596391..24e586f93855 100644 --- a/drivers/regulator/dummy.c +++ b/drivers/regulator/dummy.c @@ -45,7 +45,8 @@ static int dummy_regulator_probe(struct platform_device *pdev) config.dev = &pdev->dev; config.init_data = &dummy_initdata; - dummy_regulator_rdev = regulator_register(&dummy_desc, &config); + dummy_regulator_rdev = devm_regulator_register(&pdev->dev, &dummy_desc, + &config); if (IS_ERR(dummy_regulator_rdev)) { ret = PTR_ERR(dummy_regulator_rdev); pr_err("Failed to register regulator: %d\n", ret); |