From 49f77fff1495c0a2050fb18f9b1fc627839bbfc2 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade Date: Wed, 3 Dec 2008 05:43:34 -0200 Subject: Rework symbol visibility for easier maintenance Save in a few special cases, _X_EXPORT should not be used in C source files. Instead, it should be used in headers, and the proper C source include that header. Some special cases are symbols that need to be shared between modules, but not expected to be used by external drivers, and symbols that are accessible via LoaderSymbol/dlopen. This patch also adds conditionally some new sdk header files, depending on extensions enabled. These files were added to match pattern for other extensions/modules, that is, have the headers "deciding" symbol visibility in the sdk. These headers are: o Xext/panoramiXsrv.h, Xext/panoramiX.h o fbpict.h (unconditionally) o vidmodeproc.h o mioverlay.h (unconditionally, used only by xaa) o xfixes.h (unconditionally, symbols required by dri2) LoaderSymbol and similar functions now don't have different prototypes, in loaderProcs.h and xf86Module.h, so that both headers can be included, without the need of defining IN_LOADER. xf86NewInputDevice() device prototype readded to xf86Xinput.h, but not exported (and with a comment about it). --- randr/rrproperty.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) (limited to 'randr/rrproperty.c') diff --git a/randr/rrproperty.c b/randr/rrproperty.c index b2d414654..12923a2c7 100644 --- a/randr/rrproperty.c +++ b/randr/rrproperty.c @@ -63,7 +63,7 @@ static void RRDeliverPropertyEvent(ScreenPtr pScreen, xEvent *event) WalkTree(pScreen, DeliverPropertyEvent, event); } -_X_EXPORT void +void RRDeleteAllOutputProperties (RROutputPtr output) { RRPropertyPtr prop, next; @@ -128,7 +128,7 @@ RRDestroyOutputProperty (RRPropertyPtr prop) xfree(prop); } -_X_EXPORT void +void RRDeleteOutputProperty (RROutputPtr output, Atom property) { RRPropertyPtr prop, *prev; @@ -151,7 +151,7 @@ RRDeleteOutputProperty (RROutputPtr output, Atom property) } } -_X_EXPORT int +int RRChangeOutputProperty (RROutputPtr output, Atom property, Atom type, int format, int mode, unsigned long len, pointer value, Bool sendevent, Bool pending) @@ -276,7 +276,7 @@ RRChangeOutputProperty (RROutputPtr output, Atom property, Atom type, return(Success); } -_X_EXPORT Bool +Bool RRPostPendingProperties (RROutputPtr output) { RRPropertyValuePtr pending_value; @@ -318,7 +318,7 @@ RRPostPendingProperties (RROutputPtr output) return ret; } -_X_EXPORT RRPropertyPtr +RRPropertyPtr RRQueryOutputProperty (RROutputPtr output, Atom property) { RRPropertyPtr prop; @@ -329,7 +329,7 @@ RRQueryOutputProperty (RROutputPtr output, Atom property) return NULL; } -_X_EXPORT RRPropertyValuePtr +RRPropertyValuePtr RRGetOutputProperty (RROutputPtr output, Atom property, Bool pending) { RRPropertyPtr prop = RRQueryOutputProperty (output, property); @@ -350,7 +350,7 @@ RRGetOutputProperty (RROutputPtr output, Atom property, Bool pending) } } -_X_EXPORT int +int RRConfigureOutputProperty (RROutputPtr output, Atom property, Bool pending, Bool range, Bool immutable, int num_values, INT32 *values) @@ -407,7 +407,7 @@ RRConfigureOutputProperty (RROutputPtr output, Atom property, return Success; } -_X_EXPORT int +int ProcRRListOutputProperties (ClientPtr client) { REQUEST(xRRListOutputPropertiesReq); @@ -455,7 +455,7 @@ ProcRRListOutputProperties (ClientPtr client) return(client->noClientException); } -_X_EXPORT int +int ProcRRQueryOutputProperty (ClientPtr client) { REQUEST(xRRQueryOutputPropertyReq); @@ -504,7 +504,7 @@ ProcRRQueryOutputProperty (ClientPtr client) return(client->noClientException); } -_X_EXPORT int +int ProcRRConfigureOutputProperty (ClientPtr client) { REQUEST(xRRConfigureOutputPropertyReq); @@ -525,7 +525,7 @@ ProcRRConfigureOutputProperty (ClientPtr client) (INT32 *) (stuff + 1)); } -_X_EXPORT int +int ProcRRChangeOutputProperty (ClientPtr client) { REQUEST(xRRChangeOutputPropertyReq); @@ -582,7 +582,7 @@ ProcRRChangeOutputProperty (ClientPtr client) return client->noClientException; } -_X_EXPORT int +int ProcRRDeleteOutputProperty (ClientPtr client) { REQUEST(xRRDeleteOutputPropertyReq); @@ -605,7 +605,7 @@ ProcRRDeleteOutputProperty (ClientPtr client) return client->noClientException; } -_X_EXPORT int +int ProcRRGetOutputProperty (ClientPtr client) { REQUEST(xRRGetOutputPropertyReq); -- cgit v1.2.3