diff options
| author | Jamey Sharp <jamey@minilop.net> | 2010-05-06 21:56:10 -0700 |
|---|---|---|
| committer | Jamey Sharp <jamey@minilop.net> | 2010-05-12 18:10:01 -0700 |
| commit | 04bad1b8a118a83064316d6e4327234aee19361e (patch) | |
| tree | db53939c7cf34aa3eb3b31e6af7d32c0b31af64c /render | |
| parent | 65cedf39054cf3a1e695e84ac228cce9e8d48097 (diff) | |
Kill ChangeGC in favor of dixChangeGC.
This doesn't change any behavior, but it isn't clear whether NullClient
is correct in all cases. As ajax says,
> For most of these changes, I think it's correct to use NullClient,
> since they are server-initiated changes and should not fail for (eg)
> xace reasons. ... At any rate, you're certainly not changing any
> semantics by leaving them all as NullClient, so this patch can't be
> more wrong than before.
The call in CreateGC is particularly questionable.
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Diffstat (limited to 'render')
| -rw-r--r-- | render/mirect.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/render/mirect.c b/render/mirect.c index b54fe6fe6..0030eff62 100644 --- a/render/mirect.c +++ b/render/mirect.c @@ -70,7 +70,7 @@ miColorRects (PicturePtr pDst, (*pGC->funcs->ChangeClip) (pGC, CT_REGION, pClip, 0); } - ChangeGC (pGC, mask, tmpval); + dixChangeGC (NullClient, pGC, mask, tmpval, NULL); ValidateGC (pDst->pDrawable, pGC); if (xoff || yoff) { @@ -148,7 +148,7 @@ miCompositeRects (CARD8 op, tmpval[0] = GXcopy; tmpval[1] = pixel; - ChangeGC (pGC, GCFunction | GCForeground, tmpval); + dixChangeGC (NullClient, pGC, GCFunction | GCForeground, tmpval, NULL); ValidateGC (&pPixmap->drawable, pGC); one.x = 0; one.y = 0; |