diff options
| author | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | 2012-06-27 18:03:13 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2012-07-09 15:53:01 +0200 |
| commit | 04d4abe96ca07b851fb74125390b1b626126aa86 (patch) | |
| tree | 158d85da18ac8ad19b1c806b9d6f1abac0d71661 | |
| parent | 206e6d8551839008b6858cf8f500d2e644d2b561 (diff) | |
blockdev: warn when copy_on_read=on and readonly=on
If the image is read-only then it's not possible to copy read data into
it. Therefore copy-on-read is automatically disabled for read-only
images.
Up until now this behavior was silent, add a warning so the user knows
why copy-on-read is not working.
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | blockdev.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/blockdev.c b/blockdev.c index 9e0a72a26..a85a429ae 100644 --- a/blockdev.c +++ b/blockdev.c @@ -609,6 +609,10 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) bdrv_flags |= ro ? 0 : BDRV_O_RDWR; + if (ro && copy_on_read) { + error_report("warning: disabling copy_on_read on readonly drive"); + } + ret = bdrv_open(dinfo->bdrv, file, bdrv_flags, drv); if (ret < 0) { error_report("could not open disk image %s: %s", |