summaryrefslogtreecommitdiff
path: root/src/amd/addrlib
diff options
context:
space:
mode:
authorFrans Gu <frans.gu@amd.com>2014-12-03 05:47:09 -0500
committerMarek Olšák <marek.olsak@amd.com>2017-03-30 14:44:33 +0200
commitca6a38fd6a6b431b4f46478dfbf71452324f5377 (patch)
tree0c55a6426db70a0ead213f69fd1f2b23b17a9d50 /src/amd/addrlib
parent2bf243f7c6fdea49737a27923d7ed24bb835de22 (diff)
amdgpu/addrlib: Refine the PRT tile mode selection
Switch the tile index based on logic instead of hardcoded threshold for different ASIC.
Diffstat (limited to 'src/amd/addrlib')
-rw-r--r--src/amd/addrlib/r800/ciaddrlib.cpp68
-rw-r--r--src/amd/addrlib/r800/ciaddrlib.h2
2 files changed, 19 insertions, 51 deletions
diff --git a/src/amd/addrlib/r800/ciaddrlib.cpp b/src/amd/addrlib/r800/ciaddrlib.cpp
index 97ef3b6a8d..64fa66941f 100644
--- a/src/amd/addrlib/r800/ciaddrlib.cpp
+++ b/src/amd/addrlib/r800/ciaddrlib.cpp
@@ -912,49 +912,6 @@ BOOL_32 CiAddrLib::HwlOverrideTileMode(
/**
***************************************************************************************************
-* CiAddrLib::GetPrtSwitchP4Threshold
-*
-* @brief
-* Return the threshold of switching to P4_* instead of P16_* for PRT resources
-***************************************************************************************************
-*/
-UINT_32 CiAddrLib::GetPrtSwitchP4Threshold() const
-{
- UINT_32 threshold;
-
- switch (m_pipes)
- {
- case 8:
- threshold = 32;
- break;
- case 16:
- if (m_settings.isFiji)
- {
- threshold = 16;
- }
- else if (m_settings.isHawaii)
- {
- threshold = 8;
- }
- else
- {
- ///@todo add for possible new ASICs.
- ADDR_ASSERT_ALWAYS();
- threshold = 16;
- }
- break;
- default:
- ///@todo add for possible new ASICs.
- ADDR_ASSERT_ALWAYS();
- threshold = 32;
- break;
- }
-
- return threshold;
-}
-
-/**
-***************************************************************************************************
* CiAddrLib::HwlSetupTileInfo
*
* @brief
@@ -1185,16 +1142,29 @@ VOID CiAddrLib::HwlSetupTileInfo(
ADDR_ASSERT((index + 1) < static_cast<INT_32>(m_noOfEntries));
// Only do this when tile mode table is updated.
if (((tileMode == ADDR_TM_PRT_TILED_THIN1) || (tileMode == ADDR_TM_PRT_TILED_THICK)) &&
- (m_tileTable[index+1].mode == tileMode))
+ (m_tileTable[index + 1].mode == tileMode))
{
- UINT_32 bytesXSamples = bpp * numSamples / 8;
- UINT_32 bytesXThickness = bpp * thickness / 8;
- UINT_32 switchP4Threshold = GetPrtSwitchP4Threshold();
+ static const UINT_32 PrtTileBytes = 0x10000;
+ ADDR_TILEINFO tileInfo = {0};
+
+ HwlComputeMacroModeIndex(index, flags, bpp, numSamples, &tileInfo);
+
+ UINT_32 macroTileBytes = (bpp >> 3) * 64 * numSamples * thickness *
+ HwlGetPipes(&tileInfo) * tileInfo.banks *
+ tileInfo.bankWidth * tileInfo.bankHeight;
- if ((bytesXSamples > switchP4Threshold) || (bytesXThickness > switchP4Threshold))
+ if (macroTileBytes != PrtTileBytes)
{
- // Pick next 4 pipe entry
+ // Switching to next tile mode entry to make sure macro tile size is 64KB
index += 1;
+
+ tileInfo.pipeConfig = m_tileTable[index].info.pipeConfig;
+
+ macroTileBytes = (bpp >> 3) * 64 * numSamples * thickness *
+ HwlGetPipes(&tileInfo) * tileInfo.banks *
+ tileInfo.bankWidth * tileInfo.bankHeight;
+
+ ADDR_ASSERT(macroTileBytes == PrtTileBytes);
}
}
}
diff --git a/src/amd/addrlib/r800/ciaddrlib.h b/src/amd/addrlib/r800/ciaddrlib.h
index 92d84683c1..92997a5b46 100644
--- a/src/amd/addrlib/r800/ciaddrlib.h
+++ b/src/amd/addrlib/r800/ciaddrlib.h
@@ -169,8 +169,6 @@ private:
VOID ReadGbMacroTileCfg(
UINT_32 regValue, ADDR_TILEINFO* pCfg) const;
- UINT_32 GetPrtSwitchP4Threshold() const;
-
BOOL_32 InitTileSettingTable(
const UINT_32 *pSetting, UINT_32 noOfEntries);