diff options
| -rw-r--r-- | lib/Bitcode/Reader/BitcodeReader.cpp | 4 | ||||
| -rw-r--r-- | test/Bitcode/Inputs/invalid-metadata-not-followed-named-node.bc | bin | 0 -> 878 bytes | |||
| -rw-r--r-- | test/Bitcode/invalid.test | 5 |
3 files changed, 7 insertions, 2 deletions
diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp index 441a4c76344..4044ac80f20 100644 --- a/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/lib/Bitcode/Reader/BitcodeReader.cpp @@ -1634,9 +1634,9 @@ std::error_code BitcodeReader::ParseMetadata() { Record.clear(); Code = Stream.ReadCode(); - // METADATA_NAME is always followed by METADATA_NAMED_NODE. unsigned NextBitCode = Stream.readRecord(Code, Record); - assert(NextBitCode == bitc::METADATA_NAMED_NODE); (void)NextBitCode; + if (NextBitCode != bitc::METADATA_NAMED_NODE) + return Error("METADATA_NAME not followed by METADATA_NAMED_NODE"); // Read named metadata elements. unsigned Size = Record.size(); diff --git a/test/Bitcode/Inputs/invalid-metadata-not-followed-named-node.bc b/test/Bitcode/Inputs/invalid-metadata-not-followed-named-node.bc Binary files differnew file mode 100644 index 00000000000..42a2c3e65fe --- /dev/null +++ b/test/Bitcode/Inputs/invalid-metadata-not-followed-named-node.bc diff --git a/test/Bitcode/invalid.test b/test/Bitcode/invalid.test index eb7f979d574..43f7c77d598 100644 --- a/test/Bitcode/invalid.test +++ b/test/Bitcode/invalid.test @@ -187,3 +187,8 @@ RUN: not llvm-dis -disable-output %p/Inputs/invalid-array-operand-encoding.bc 2> RUN: FileCheck --check-prefix=ARRAY-OP-ENC %s ARRAY-OP-ENC: Array element type has to be an encoding of a type + +RUN: not llvm-dis -disable-output %p/Inputs/invalid-metadata-not-followed-named-node.bc 2>&1 | \ +RUN: FileCheck --check-prefix=META-NOT-FOLLOWED-BY-NAMED-META %s + +META-NOT-FOLLOWED-BY-NAMED-META: METADATA_NAME not followed by METADATA_NAMED_NODE |