diff options
author | Teresa Johnson <tejohnson@google.com> | 2015-12-03 18:20:05 +0000 |
---|---|---|
committer | Teresa Johnson <tejohnson@google.com> | 2015-12-03 18:20:05 +0000 |
commit | 1c14f2864d7e7b87609c9d4c9b8295d0140ec978 (patch) | |
tree | 0c7a231a823347aa6e0c9b672d4eed9f48065551 /test/Linker | |
parent | 83c34652ffe9b368401aea98d9a4cc1ef6fa32d3 (diff) |
[ThinLTO] Appending linkage fixes
Summary:
Fix import from module with appending var, which cannot be imported. The
first fix is to remove an overly-aggressive error check.
The second fix is to deal with restructuring introduced to the module
linker yesterday in r254418 (actually, this fix was included already
in r254559, just added some additional cleanup).
Test by Mehdi Amini.
Reviewers: joker.eph, rafael
Subscribers: joker.eph, llvm-commits
Differential Revision: http://reviews.llvm.org/D15156
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@254624 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'test/Linker')
-rw-r--r-- | test/Linker/Inputs/funcimport_appending_global.ll | 6 | ||||
-rw-r--r-- | test/Linker/funcimport_appending_global.ll | 20 |
2 files changed, 26 insertions, 0 deletions
diff --git a/test/Linker/Inputs/funcimport_appending_global.ll b/test/Linker/Inputs/funcimport_appending_global.ll new file mode 100644 index 00000000000..413b890b02a --- /dev/null +++ b/test/Linker/Inputs/funcimport_appending_global.ll @@ -0,0 +1,6 @@ +@v = weak global i8 1 +@llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @foo, i8* @v}] + +define void @foo() { + ret void +} diff --git a/test/Linker/funcimport_appending_global.ll b/test/Linker/funcimport_appending_global.ll new file mode 100644 index 00000000000..190d31ee8c7 --- /dev/null +++ b/test/Linker/funcimport_appending_global.ll @@ -0,0 +1,20 @@ +; RUN: llvm-as -function-summary %s -o %t.bc +; RUN: llvm-as -function-summary %p/Inputs/funcimport_appending_global.ll -o %t2.bc +; RUN: llvm-lto -thinlto -o %t3 %t.bc %t2.bc + +; Do the import now +; RUN: llvm-link %t.bc -functionindex=%t3.thinlto.bc -import=foo:%t2.bc -S | FileCheck %s + +; Ensure that global constructor (appending linkage) is not imported +; CHECK-NOT: @llvm.global_ctors = {{.*}}@foo + +declare void @f() +@llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @f, i8* null}] + +define i32 @main() { +entry: + call void @foo() + ret i32 0 +} + +declare void @foo() |