summaryrefslogtreecommitdiff
path: root/autogen.sh
diff options
context:
space:
mode:
authorPeter Hutterer <peter.hutterer@who-t.net>2009-10-01 10:03:42 +1000
committerPeter Hutterer <peter.hutterer@who-t.net>2009-10-01 16:27:36 +1000
commit47c0b80915d67346ec63b36b659a96b77e777a71 (patch)
tree209864b3061f9b2bef8f5cd13da909147d17a436 /autogen.sh
parent30ebee3bfcadf915be98d407610c615e3e00f9c1 (diff)
render: Fix crash in RenderAddGlyphs (#23645)
This patch fixes two bugs: size is calculated as glyph height * padded_width. If the client submits garbage, this may get above INT_MAX, resulting in a negative size if size is unsigned. The sanity checks don't trigger for negative sizes and the server goes and writes into random memory locations. If the client submits glyphs with a width or height 0, the destination pixmap is NULL, causing a null-pointer dereference. Since there's nothing to composite if the width/height is 0, we might as well skip the whole thing anyway. Tested with Xvfb, Xephyr and Xorg. X.Org Bug 23645 <http://bugs.freedesktop.org/show_bug.cgi?id=23645> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Keith Packard <keithp@keithp.com> (cherry picked from commit 622fc98fd08aba98369e6933c3ab8c9ff85385d5)
Diffstat (limited to 'autogen.sh')
0 files changed, 0 insertions, 0 deletions