summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDylan Baker <baker.dylan.c@gmail.com>2015-01-30 13:33:33 -0800
committerDylan Baker <baker.dylan.c@gmail.com>2015-03-05 09:46:48 -0800
commit22b24f58d1c2a12ca79b2324b5a2846fbfc862ac (patch)
tree39329d940565125e9533ad1c8715f5c89365e97f
parent491bded384452e0b7fe7b38fe9cec9b05a5fc81a (diff)
all.py: disable pylint's bad-continuation error
This is a bug (https://bitbucket.org/logilab/pylint/issue/461/incorrect-hanging-indent-detection-with) that misdetects the hanging indent of the context manager. This silences roughly 300 warnings. v2: - also turn this warning off in quick.py Signed-off-by: Dylan Baker <dylanx.c.baker@intel.com>
-rw-r--r--tests/all.py6
-rw-r--r--tests/quick.py3
2 files changed, 9 insertions, 0 deletions
diff --git a/tests/all.py b/tests/all.py
index b0348fcd9..61fa1e21a 100644
--- a/tests/all.py
+++ b/tests/all.py
@@ -14,6 +14,12 @@ from .py_modules.constants import TESTS_DIR, GENERATED_TESTS_DIR
__all__ = ['profile']
+# Disable bad hanging indent errors in pylint
+# There is a bug in pyling which causes the profile.group_manager to be tagged
+# as bad hanging indent, even though it seems to be correct (and similar syntax
+# doesn't trigger an error)
+# pylint: disable=bad-continuation
+
def add_single_param_test_set(adder, name, *params):
for param in params:
diff --git a/tests/quick.py b/tests/quick.py
index 41790c546..5393a2be9 100644
--- a/tests/quick.py
+++ b/tests/quick.py
@@ -6,6 +6,9 @@ from tests.all import profile
__all__ = ['profile']
+# See the note in all.py about this warning
+# pylint: disable=bad-continuation
+
GleanTest.GLOBAL_PARAMS += ["--quick"]
# Set the --quick flag on a few image_load_store_tests