diff options
| author | Carl Worth <cworth@cworth.org> | 2009-07-31 11:20:23 -0700 |
|---|---|---|
| committer | Carl Worth <cworth@cworth.org> | 2009-08-31 09:30:40 -0700 |
| commit | 5812531e08147576de776b2dd64e7f94c08eb851 (patch) | |
| tree | 360b3cec47ee2a801dc9d5bb82337548339f07ae | |
| parent | 7c48c21b22bf5862c5a35bda1635753cc5a7197c (diff) | |
debug: i830_valid_command: Return invalid for subopcodes with no name
Previously the code would always return the count, before ever looking
into the _3d_cmds table to see if there was actually a valid command.
Thanks to Alan Coopersmith who reported that the code was confusing
parfait:
https://bugs.freedesktop.org/show_bug.cgi?id=21666
| -rw-r--r-- | src/i830_debug.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/i830_debug.c b/src/i830_debug.c index 1333796b..cf3f4396 100644 --- a/src/i830_debug.c +++ b/src/i830_debug.c @@ -2113,8 +2113,6 @@ i830_valid_command (uint32_t cmd) count = 1; else count = (cmd & 0xff) + 2; - if (pipeline_type <= 3) - return count; if (!_3d_cmds[pipeline_type][opcode][subopcode].name) return -1; break; |