From 49f77fff1495c0a2050fb18f9b1fc627839bbfc2 Mon Sep 17 00:00:00 2001 From: Paulo Cesar Pereira de Andrade Date: Wed, 3 Dec 2008 05:43:34 -0200 Subject: Rework symbol visibility for easier maintenance Save in a few special cases, _X_EXPORT should not be used in C source files. Instead, it should be used in headers, and the proper C source include that header. Some special cases are symbols that need to be shared between modules, but not expected to be used by external drivers, and symbols that are accessible via LoaderSymbol/dlopen. This patch also adds conditionally some new sdk header files, depending on extensions enabled. These files were added to match pattern for other extensions/modules, that is, have the headers "deciding" symbol visibility in the sdk. These headers are: o Xext/panoramiXsrv.h, Xext/panoramiX.h o fbpict.h (unconditionally) o vidmodeproc.h o mioverlay.h (unconditionally, used only by xaa) o xfixes.h (unconditionally, symbols required by dri2) LoaderSymbol and similar functions now don't have different prototypes, in loaderProcs.h and xf86Module.h, so that both headers can be included, without the need of defining IN_LOADER. xf86NewInputDevice() device prototype readded to xf86Xinput.h, but not exported (and with a comment about it). --- mi/miwindow.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) (limited to 'mi/miwindow.c') diff --git a/mi/miwindow.c b/mi/miwindow.c index 8e4be64e5..e2af77d48 100644 --- a/mi/miwindow.c +++ b/mi/miwindow.c @@ -57,7 +57,7 @@ SOFTWARE. #include "pixmapstr.h" #include "mivalidate.h" -_X_EXPORT void +void miClearToBackground(WindowPtr pWin, int x, int y, int w, int h, Bool generateExposures) @@ -122,7 +122,7 @@ miClearToBackground(WindowPtr pWin, REGION_DESTROY(pScreen, pBSReg); } -_X_EXPORT void +void miMarkWindow(WindowPtr pWin) { ValidatePtr val; @@ -137,7 +137,7 @@ miMarkWindow(WindowPtr pWin) pWin->valdata = val; } -_X_EXPORT Bool +Bool miMarkOverlappedWindows(WindowPtr pWin, WindowPtr pFirst, WindowPtr *ppLayerWin) { BoxPtr box; @@ -223,7 +223,7 @@ miMarkOverlappedWindows(WindowPtr pWin, WindowPtr pFirst, WindowPtr *ppLayerWin) * regions, translate the regions, restore any backing store, * and then send any regions still exposed to the client *****/ -_X_EXPORT void +void miHandleValidateExposures(WindowPtr pWin) { WindowPtr pChild; @@ -260,7 +260,7 @@ miHandleValidateExposures(WindowPtr pWin) } } -_X_EXPORT void +void miMoveWindow(WindowPtr pWin, int x, int y, WindowPtr pNextSib, VTKind kind) { WindowPtr pParent; @@ -369,7 +369,7 @@ miRecomputeExposures ( return WT_NOMATCH; } -_X_EXPORT void +void miSlideAndSizeWindow(WindowPtr pWin, int x, int y, unsigned int w, unsigned int h, @@ -681,7 +681,7 @@ miSlideAndSizeWindow(WindowPtr pWin, WindowsRestructured (); } -_X_EXPORT WindowPtr +WindowPtr miGetLayerWindow(WindowPtr pWin) { return pWin->firstChild; @@ -694,7 +694,7 @@ miGetLayerWindow(WindowPtr pWin) * and send appropriate exposure events */ -_X_EXPORT void +void miSetShape(WindowPtr pWin) { Bool WasViewable = (Bool)(pWin->viewable); @@ -750,7 +750,7 @@ miSetShape(WindowPtr pWin) /* Keeps the same inside(!) origin */ -_X_EXPORT void +void miChangeBorderWidth(WindowPtr pWin, unsigned int width) { int oldwidth; @@ -804,7 +804,7 @@ miChangeBorderWidth(WindowPtr pWin, unsigned int width) WindowsRestructured (); } -_X_EXPORT void +void miMarkUnrealizedWindow(WindowPtr pChild, WindowPtr pWin, Bool fromConfigure) { if ((pChild != pWin) || fromConfigure) @@ -816,7 +816,7 @@ miMarkUnrealizedWindow(WindowPtr pChild, WindowPtr pWin, Bool fromConfigure) } } -_X_EXPORT void +void miSegregateChildren(WindowPtr pWin, RegionPtr pReg, int depth) { ScreenPtr pScreen; -- cgit v1.2.3