From 2935bbc520e87b139f474e9719dc7ea77c76a803 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Sat, 29 Nov 2014 05:52:51 +0000 Subject: Make RecordKeeper::addClass/addDef take unique_ptrs instead of creating one internally. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@222948 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/TableGen/TGParser.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'lib') diff --git a/lib/TableGen/TGParser.cpp b/lib/TableGen/TGParser.cpp index c594da8b350..8f83714d32e 100644 --- a/lib/TableGen/TGParser.cpp +++ b/lib/TableGen/TGParser.cpp @@ -371,7 +371,7 @@ bool TGParser::ProcessForeachDefs(Record *CurRec, SMLoc Loc, IterSet &IterVals){ } Record *IterRecSave = IterRec.get(); // Keep a copy before release. - Records.addDef(IterRec.release()); + Records.addDef(std::move(IterRec)); IterRecSave->resolveReferences(); return false; } @@ -1252,7 +1252,7 @@ Init *TGParser::ParseSimpleValue(Record *CurRec, RecTy *ItemType, if (!CurMultiClass) { NewRec->resolveReferences(); - Records.addDef(NewRecOwner.release()); + Records.addDef(std::move(NewRecOwner)); } else { // This needs to get resolved once the multiclass template arguments are // known before any use. @@ -2044,7 +2044,7 @@ bool TGParser::ParseDef(MultiClass *CurMultiClass) { if (Records.getDef(CurRec->getNameInitAsString())) return Error(DefLoc, "def '" + CurRec->getNameInitAsString()+ "' already defined"); - Records.addDef(CurRecOwner.release()); + Records.addDef(std::move(CurRecOwner)); if (ParseObjectBody(CurRec)) return true; @@ -2169,8 +2169,10 @@ bool TGParser::ParseClass() { + "' already defined"); } else { // If this is the first reference to this class, create and add it. - CurRec = new Record(Lex.getCurStrVal(), Lex.getLoc(), Records); - Records.addClass(CurRec); + auto NewRec = make_unique(Lex.getCurStrVal(), Lex.getLoc(), + Records); + CurRec = NewRec.get(); + Records.addClass(std::move(NewRec)); } Lex.Lex(); // eat the name. @@ -2442,7 +2444,7 @@ InstantiateMulticlassDef(MultiClass &MC, } Record *CurRecSave = CurRec.get(); // Keep a copy before we release. - Records.addDef(CurRec.release()); + Records.addDef(std::move(CurRec)); return CurRecSave; } -- cgit v1.2.3