summaryrefslogtreecommitdiff
path: root/audio
AgeCommit message (Collapse)AuthorFilesLines
2012-03-15HFP gateway: fix failure on very first GSM connectionArnaud Mouiche1-2/+2
This patch fix the very first incoming connection from a GSM device (playing the gateway role), when 'device->gateway' is NULL (when we didn't perform a SDP browse request yet) we add the service with 'btd_device_add_uuid(device->btd_dev, remote_uuid)' but we provide HFP_HS_UUID as remote_uuid. Consequently, the HFP headset service is activated instead the gateway service.
2012-03-13audio: fix io channel shutdown on errorMikel Astiz1-5/+8
In the unlikely case of service record allocation error, the io channel should be properly shut down.
2012-03-13audio: fix missing io channel shutdownMikel Astiz1-0/+2
Channel must be explicitly shut down because otherwise the reference counter never reaches zero, due to the server installed by bt_io_listen.
2012-03-13audio: fix missing unref in case of errorMikel Astiz1-3/+18
audio_adapter_get() increases the reference counter of the adapter, so it's necessary to decrement it in case of error.
2012-03-13avrcp: Add error code for rejected vendor commandMichal Labedzki3-1/+20
Fix response for any vendor commands when there are no players registered. According to the specification responses should be REJECTED with error code. "For error response PDU the response parameter is always the error code independent of the response format defined for ACCEPTED PDU response for the corresponding PDU command." (source: section 4.7.9 of AVRCP 1.3 specification)
2012-03-13avrcp: Fix response ctype of AbortContinuingResponseMichal Labedzki1-1/+1
Request ctype of "AbortContinuingResponse" is CONTROL, so response should be ACCEPTED instead of STABLE. This affect PTS Test Case for TP/RCR/BV-04-C.
2012-03-08media: register disconnect watch at transport addFrédéric Dalleau1-3/+3
disconnect watch is not removed when the media owner is freed if an error occurs while resuming in acquire (id == 0).
2012-03-08gateway: Fix crash if SCO connection failsFrédéric Dalleau1-4/+1
In some situations, a connect callback is created, but this callback is not added to media_owner. Thus when the owner is destroyed and at rfcomm disconnect, the callback is executed with an invalid pointer.
2012-03-02audio: Remove redundant state_changed() call in headset_server_probe()Johan Hedberg1-1/+0
2012-02-17audio: Fix signature of MediaTransport.Acquire methodLuiz Augusto von Dentz1-1/+1
Acquire returns the input and output MTUs in addition to the file descriptor, but the signature doesn't indicate that.
2012-02-14audio: Fix clang compiler warnings regarding implicit enum conversionVinicius Costa Gomes4-6/+6
It was expected that source_get_state() returned a source_state_t, and that sink_get_state() returned a sink_state_t.
2012-02-14audio: do not disconnect on gateway SCO failureMikel Astiz1-1/+1
Failure on BlueZ-initiated SCO requests should not drop the RFCOMM connection to the gateway. Instead, considering the stream as suspended should be enough.
2012-02-14a2dp: return NotSupported error if no server foundMikel Astiz1-1/+1
With both sink and sources disabled, the A2DP server is not even registered in audio_manager_init. When trying to register the endpoint, this should result in the same error as if the server existed but the profile was disabled.
2012-02-14audio: gateway_unlock together with in_use = FALSEMikel Astiz1-1/+2
Calling gateway_unlock seems safer in gateway_suspend_complete, in combination with the update of transport->in_use. This avoids the transitional state of having the gateway unlocked but the transport still in use. This approach is also more consistent with the way headset and a2dp handle it.
2012-02-02Fix GLib assertion failure in media.c get_setting()Szymon Janc1-3/+2
If get_setting is called before set_setting, mp->settings would be NULL resulting in GLib assertion. Hashmap is now allocated in media_player_create instead of on-demand allocation in set_setting. external/bluetooth/bluez/audio/media.c:get_setting() Equalizer CRITICAL **: g_hash_table_lookup: assertion `hash_table != NULL' failed
2012-01-27audio: Fix disabling local A2DP endpoints when UNIX socket is disabledLuiz Augusto von Dentz1-8/+7
Local endpoints can only be used when UNIX socket API is available.
2012-01-24btio: Fix users to not expect a default security levelVinicius Costa Gomes3-0/+4
The users of btio should not expect that btio will set the security level to medium if it wasn't specified. Now, all the users specfify the security level needed.
2012-01-12headset: Fix unknown command error responseSyam Sidhardhan1-1/+2
If HF has already requested for the Extended Error result code reporting, then send the same in certain failure cases. Earlier in this case we were sending normal error.
2012-01-09Remove PulseAudio plugin leftoverAnderson Lizardo1-39/+0
The .c file and the configure check were not being used anywhere.
2011-12-27audio: Use headset_shutdown in headset_setconf_cbRadoslaw Jablonski1-1/+1
If pending connection will stay after state has been changed to HEADSET_STATE_DISCONNECTED, then crash may happen (e.g. when hs_connect will be called quickly again after that) To avoid that kind of problems using headset_shutdown, which does necessary cleanup first (finalizes pending connections) and after that changes state to HEADSET_STATE_DISCONNECTED.
2011-12-23Fix device address type trackingJohan Hedberg1-1/+1
2011-12-08telephony-maemo5: Fix D-Bus reply memory leaksSyam Sidhardhan1-4/+4
2011-11-21media: update copyright statementMikel Astiz1-0/+1
2011-11-21a2dp: update copyright statementMikel Astiz2-0/+2
2011-11-21a2dp: avoid conversion between guint and pointersMikel Astiz3-27/+22
These conversions might cause a segmentation fault in 64 bit machines.
2011-11-21media: sep registration fixMikel Astiz1-1/+1
2011-11-21media: release transport locks on acquisition failureMikel Astiz1-0/+1
2011-11-21audio: enable Media API by defaultLuiz Augusto von Dentz1-2/+2
This replaces unix socket IPC which is considered deprecated and will eventually be removed.
2011-11-18AVDTP: Fix closing invalid FD on errorAnderson Lizardo1-1/+1
In gst_avdtp_sink_start(), if bt_audio_service_open() failed, there was an attempt to close an invalid file descriptor (through bt_audio_service_close()).
2011-11-17Fix return value check for bt_audio_service_open()Anderson Lizardo2-2/+2
Only negative values (namely -1) are errors for this function.
2011-11-17audio: Fix errno handling conventionAnderson Lizardo2-15/+19
Variables which are assigned to the errno variable (usually called "err") should be negative, and "-err" should be used where a positive value is needed.
2011-11-17audio/PCM: Fix errno handling conventionAnderson Lizardo1-10/+11
Variables which are assigned to the errno variable (usually called "err") should be negative, and "-err" should be used where a positive value is needed.
2011-11-17audio/IPC: Fix errno handling conventionAnderson Lizardo1-9/+9
Variables which are assigned to the errno variable (usually called "err") should be negative, and "-err" should be used where a positive value is needed. This commit also changes places where errno can be replaced with -err (for consistency) and one perror() usage error.
2011-11-17AVDTP: Fix errno handling conventionAnderson Lizardo1-10/+12
Variables which are assigned to the errno variable (usually called "err") should be negative, and "-err" should be used where a positive value is needed.
2011-11-17AVCTP: Fix errno handling conventionAnderson Lizardo1-18/+13
Variables which are assigned to the errno variable (usually called "err") should be negative, and "-err" should be used where a positive value is needed. This patch also fixes a bug related to not using an "err" variable to store the errno value before calling external library code.
2011-11-14Fix enable fast connectable when connection allowedDmitriy Paliy1-1/+6
2011-11-04AVRCP: implement TRACK-REACHED-END eventLucas De Marchi3-0/+17
2011-11-02Fix response on AT+CHLD=0 in maemo6Dmitriy Paliy1-3/+7
Currently, +CIEV indicator after AT+CHLD=0 command for one active call, one held call, one incoming call scenario is incorrect. callheld=2 according to HFP 1.5 spec., p.70, means 'Call on hold, no active call'. Hence, value 2 cannot be provided in +CIEV if there is an active call.
2011-10-28Add MediaPlayer.Release methodLuiz Augusto von Dentz1-1/+25
This is similar to MediaEndpoint.Release which is useful to notify the player that it is no longer registered/active.
2011-10-28Fix incorrect use of atoi in maemo6Dmitriy Paliy1-1/+4
Use of atoi is incorrect and unsafe in maemo6 telephony and replaced by g_ascii_digit_value.
2011-10-28Fix check for PDU sizeLucas De Marchi1-1/+1
Company ID became part of the avrcp header so its size is already accounted in the AVRCP_HEADER_LENGTH define.
2011-10-25Fix calling g_io_channel_shutdown twice for a gateway connectionLuiz Augusto von Dentz1-1/+0
This happens in the following circumstance: bluetoothd[30869]: audio/manager.c:hf_io_cb() Authorization denied! (bluetoothd:30869): GLib-WARNING **: Invalid file descriptor. Reported by Daniel Wagner <wagi@monom.org>
2011-10-22Unregister players' events when disconnectedLucas De Marchi1-0/+1
2011-10-22Fix leak of GTimerLucas De Marchi1-0/+1
2011-10-22Add missing TRACK-REACHED-START eventLucas De Marchi1-0/+2
When track is changed, we automatically start to play it, therefore we need to notify CT regarding this event.
2011-10-18Fix implicit declaration of 'g_slist_free_full'Frédéric Danis1-1/+1
audio/avrcp.c: In function 'avrcp_unregister': audio/avrcp.c:1253: error: implicit declaration of function 'g_slist_free_full' thermometer/thermometer.c: In function 'destroy_char': thermometer/thermometer.c:79: error: implicit declaration of function 'g_slist_free_full'
2011-10-18Move SDP client functions from glib-helper.c to sdp-client.cJohan Hedberg2-2/+2
2011-10-18Add glib-compat.h to deal with issues in old GLib versionsJohan Hedberg7-5/+7
2011-10-18AVRCP: Implement RequestContinuingResponse PDULucas De Marchi1-68/+146
2011-10-18AVRCP: Implement AbortContinuingResponse PDULucas De Marchi1-0/+55