Age | Commit message (Collapse) | Author | Files | Lines |
|
This patch fix the very first incoming connection from a GSM device
(playing the gateway role), when 'device->gateway' is NULL (when we
didn't perform a SDP browse request yet)
we add the service with 'btd_device_add_uuid(device->btd_dev,
remote_uuid)' but we provide HFP_HS_UUID as remote_uuid. Consequently,
the HFP headset service is activated instead the gateway service.
|
|
In the unlikely case of service record allocation error, the io channel
should be properly shut down.
|
|
Channel must be explicitly shut down because otherwise the reference
counter never reaches zero, due to the server installed by bt_io_listen.
|
|
audio_adapter_get() increases the reference counter of the adapter, so
it's necessary to decrement it in case of error.
|
|
Fix response for any vendor commands when there are no players
registered. According to the specification responses should be
REJECTED with error code.
"For error response PDU the response parameter is always the
error code independent of the response format defined for
ACCEPTED PDU response for the corresponding PDU command."
(source: section 4.7.9 of AVRCP 1.3 specification)
|
|
Request ctype of "AbortContinuingResponse" is CONTROL, so response
should be ACCEPTED instead of STABLE. This affect PTS Test Case for
TP/RCR/BV-04-C.
|
|
disconnect watch is not removed when the media owner is freed if
an error occurs while resuming in acquire (id == 0).
|
|
In some situations, a connect callback is created, but
this callback is not added to media_owner. Thus when the owner
is destroyed and at rfcomm disconnect, the callback is executed
with an invalid pointer.
|
|
|
|
Acquire returns the input and output MTUs in addition to the file
descriptor, but the signature doesn't indicate that.
|
|
It was expected that source_get_state() returned a source_state_t, and
that sink_get_state() returned a sink_state_t.
|
|
Failure on BlueZ-initiated SCO requests should not drop the RFCOMM
connection to the gateway. Instead, considering the stream as suspended
should be enough.
|
|
With both sink and sources disabled, the A2DP server is not even
registered in audio_manager_init. When trying to register the endpoint,
this should result in the same error as if the server existed but the
profile was disabled.
|
|
Calling gateway_unlock seems safer in gateway_suspend_complete, in
combination with the update of transport->in_use. This avoids the
transitional state of having the gateway unlocked but the transport
still in use.
This approach is also more consistent with the way headset and a2dp
handle it.
|
|
If get_setting is called before set_setting, mp->settings would be
NULL resulting in GLib assertion. Hashmap is now allocated in
media_player_create instead of on-demand allocation in set_setting.
external/bluetooth/bluez/audio/media.c:get_setting() Equalizer
CRITICAL **: g_hash_table_lookup: assertion `hash_table != NULL' failed
|
|
Local endpoints can only be used when UNIX socket API is available.
|
|
The users of btio should not expect that btio will set the security
level to medium if it wasn't specified. Now, all the users specfify
the security level needed.
|
|
If HF has already requested for the Extended Error result code
reporting, then send the same in certain failure cases. Earlier in this
case we were sending normal error.
|
|
The .c file and the configure check were not being used anywhere.
|
|
If pending connection will stay after state has been changed to
HEADSET_STATE_DISCONNECTED, then crash may happen (e.g. when hs_connect
will be called quickly again after that) To avoid that kind of problems
using headset_shutdown, which does necessary cleanup first (finalizes
pending connections) and after that changes state to
HEADSET_STATE_DISCONNECTED.
|
|
|
|
|
|
|
|
|
|
These conversions might cause a segmentation fault in 64 bit machines.
|
|
|
|
|
|
This replaces unix socket IPC which is considered deprecated and will
eventually be removed.
|
|
In gst_avdtp_sink_start(), if bt_audio_service_open() failed, there was
an attempt to close an invalid file descriptor (through
bt_audio_service_close()).
|
|
Only negative values (namely -1) are errors for this function.
|
|
Variables which are assigned to the errno variable (usually called
"err") should be negative, and "-err" should be used where a positive
value is needed.
|
|
Variables which are assigned to the errno variable (usually called
"err") should be negative, and "-err" should be used where a positive
value is needed.
|
|
Variables which are assigned to the errno variable (usually called
"err") should be negative, and "-err" should be used where a positive
value is needed.
This commit also changes places where errno can be replaced with -err
(for consistency) and one perror() usage error.
|
|
Variables which are assigned to the errno variable (usually called
"err") should be negative, and "-err" should be used where a positive
value is needed.
|
|
Variables which are assigned to the errno variable (usually called
"err") should be negative, and "-err" should be used where a positive
value is needed.
This patch also fixes a bug related to not using an "err" variable to
store the errno value before calling external library code.
|
|
|
|
|
|
Currently, +CIEV indicator after AT+CHLD=0 command for one active call,
one held call, one incoming call scenario is incorrect. callheld=2
according to HFP 1.5 spec., p.70, means 'Call on hold, no active call'.
Hence, value 2 cannot be provided in +CIEV if there is an active call.
|
|
This is similar to MediaEndpoint.Release which is useful to notify the
player that it is no longer registered/active.
|
|
Use of atoi is incorrect and unsafe in maemo6 telephony and replaced
by g_ascii_digit_value.
|
|
Company ID became part of the avrcp header so its size is already
accounted in the AVRCP_HEADER_LENGTH define.
|
|
This happens in the following circumstance:
bluetoothd[30869]: audio/manager.c:hf_io_cb() Authorization denied!
(bluetoothd:30869): GLib-WARNING **: Invalid file descriptor.
Reported by Daniel Wagner <wagi@monom.org>
|
|
|
|
|
|
When track is changed, we automatically start to play it, therefore we
need to notify CT regarding this event.
|
|
audio/avrcp.c: In function 'avrcp_unregister':
audio/avrcp.c:1253: error: implicit declaration of function 'g_slist_free_full'
thermometer/thermometer.c: In function 'destroy_char':
thermometer/thermometer.c:79: error: implicit declaration of function 'g_slist_free_full'
|
|
|
|
|
|
|
|
|