summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-12-20Version 0.12.7telepathy-glib-0.12.7Will Thompson2-3/+6
2010-12-16NEWSSimon McVittie1-1/+2
2010-12-16Merge branch '012-noc-fixes' into telepathy-glib-0.12Simon McVittie2-267/+360
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32391
2010-12-16fix a typo in the test, and make even more assertionsSimon McVittie1-3/+7
2010-12-16tests/dbus/dbus: cancel_watch_during_dispatch: assert that user_data is freedSimon McVittie1-1/+18
2010-12-16Fix iteration over arrays of name-owner watchesSimon McVittie1-5/+10
Also document why we're iterating backwards. In tp_dbus_daemon_maybe_free_name_owner_watch, the flawed reverse-iteration was a bug: we'd skip over the element before a removed entry, which might mean not freeing it. In tp_dbus_daemon_cancel_name_owner_watch, it was done correctly (because there were no deletions), but it did hurt clarity.
2010-12-16Add a test case for removing name watches during dispatchWill Thompson1-0/+75
This test case failed before the previous patch.
2010-12-16Don't remove NameOwnerChanged callbacks while invoking themSimon McVittie1-23/+58
2010-12-14Simplify dispatching NameOwnerChanged signals.Will Thompson1-97/+52
Previously there was this weird model where TpDBusDaemon had a dict mapping bus names being watched to a watch struct. The watch struct had a callback and some user data. When the library user first added a watch for a name, their callback would be shoved into a new struct that was put into the dict, and all was bright. But when a second call to _watch_name_owner() came along … a GArray of "sub watches" would be created, the old callback copied into it and the new callback added to it, and then the original struct's callback would be replaced by an callback that iterates the subwatches. I couldn't see any good reason not to always have a list of callbacks, so deleted that code. Now all watches have a list of callbacks, and it's a bit clearer. Making this change found a nasty bug where, if one callback removes its own watch, subsequent callbacks may not be called for this signal. Test case and fix to follow.
2010-12-14Make 'dbus' test use GTest.Will Thompson1-98/+112
2010-12-14Modernize 'dbus' test a bit.Will Thompson1-132/+120
This excellently named test tests TpDBusDaemon and a bunch of utility functions which should be in libdbus, but aren't. MYASSERT brings me out in a rash. MYASSERT (foo, "") actually causes boils to sprout fully formed from my neck.
2010-12-13NEWS for minor fixes from fd.o#32184Will Thompson1-0/+8
2010-12-13Merge branch 'fd.o-32184-trivial-fixes' into telepathy-glib-0.12Will Thompson2-6/+15
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
2010-12-13AM.ensure_account(): Don't critical on invalid pathsWill Thompson1-5/+11
Currently, tp_account_manager_ensure_account() g_return_val_if_fail()s if tp_account_new() returns NULL, but doesn't actually check the path that the user passes in, so the latter can quite legitimately return NULL. So, let's return NULL cleanly instead.
2010-12-13BaseClient.ObserveChannels: handle broken connection pathsWill Thompson1-1/+4
Previously, if someone passed an invalid connection path to ObserveChannels, tp-glib wouldn't pass the call up to the application, but nor would it return an error from the method. This manifested itself in the logger failing to return (or indeed log messages) when I hit <https://bugs.freedesktop.org/show_bug.cgi?id=32184>.
2010-12-10Nano versionSimon McVittie2-1/+6
2010-12-10Prepare version 0.12.6telepathy-glib-0.12.6Simon McVittie2-4/+6
2010-12-10_is-release-check: fail check if there are changes stagedSimon McVittie1-0/+4
2010-12-10NEWSSimon McVittie1-0/+5
2010-12-10Use WARNING instead of g_warningXavier Claessens1-1/+1
2010-12-10Correctly Close() handled channelsXavier Claessens3-9/+85
2010-12-10Avoid potential problems if channel is already invalidatedXavier Claessens1-4/+3
In that case no extra ref is added on self and handle_request_complete() could make it dispose. Self is the owner of context, so the tp_handle_channels_context_accept() call following could break things.
2010-12-10Warning if TpBaseClient is still handling channels at disposeXavier Claessens1-0/+4
2010-12-10Document that handlers are responsible to call Close() on handled channelsXavier Claessens2-0/+9
2010-12-10Fix leaked TpChannel objectsXavier Claessens1-1/+1
2010-12-08NEWSSimon McVittie1-0/+3
2010-12-08Merge branch '012-contact' into telepathy-glib-0.12Simon McVittie3-130/+597
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32191
2010-12-08contacts test: add regression tests for fd.o #25181 and #32191Simon McVittie1-0/+158
2010-12-08Add a regression test for fd.o #32191 where it was first exhibitedSimon McVittie1-0/+15
2010-12-08fd.o #32191: tp_connection_get_contacts_by_handle: call GetAttributes if ↵Simon McVittie1-0/+7
necessary
2010-12-08contacts_held_handles: guard against being called unnecessarilySimon McVittie1-0/+1
2010-12-08contacts_get_attributes: skip if we're not going to achieve anythingSimon McVittie1-1/+26
2010-12-08Always call contacts_get_attributes via the context->todo queueSimon McVittie1-5/+4
2010-12-08tp_connection_get_contacts_by_handle: if all contacts have a feature, skip itSimon McVittie1-0/+7
2010-12-08contacts_get_attributes: don't hold handles if we don't still need toSimon McVittie1-6/+5
2010-12-08contacts_context_queue_features: don't take an extra parameterSimon McVittie1-7/+8
The context already knows what feature flags it wants.
2010-12-08contacts-slow-path: add regression tests for fd.o #25181, #32191Simon McVittie1-0/+173
The slow path never actually suffered from #32191.
2010-12-08contacts test: use GTesterSimon McVittie1-44/+18
2010-12-08contacts test: pass the fixture to all testsSimon McVittie1-36/+52
2010-12-08contacts test: do setup, teardown once per testSimon McVittie1-5/+25
2010-12-08contacts test: encapsulate setup/teardown using a fixtureSimon McVittie1-45/+84
2010-12-08contacts-slow-path: use GTesterSimon McVittie1-35/+39
2010-12-08contacts-slow-path: do setup and teardown individually for each testSimon McVittie1-2/+12
2010-12-08contacts-slow-path: make teardown survive missing objectsSimon McVittie1-6/+13
Also hold a separate ref for base_connection and legacy_service_conn.
2010-12-08contacts-slow-path: encapsulate test state in a fixtureSimon McVittie1-24/+36
2010-12-06NEWSSimon McVittie1-1/+7
2010-12-06Merge branches '012-base-cm-shutdown' and '012-leaked-protocol' into ↵Simon McVittie1-2/+5
telepathy-glib-0.12 Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32116
2010-12-06TpBaseConnectionManager: ref the CM once per ConnectionSimon McVittie1-5/+13
Some Salut test failures can apparently cause the Connection to outlive the CM, causing a crash when it emits no-more-connections.
2010-12-06fd.o #32116: tp_base_connection_manager_register: don't leak protocol refsSimon McVittie1-2/+5
2010-11-25Nano versionSimon McVittie2-1/+6
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-21 17:55:05 +0000