panvk: Fix Cube/2DArray/3D img -> buf copies

Not that I really care about fixing copies now that vk_meta_copy is on
its way, but it fixes OOB accesses causing new crashes after the
panvk_mempool changes.

Fixes: f73ae1a6b565 ("panvk: Implement vkCmdCopyImageToBuffer()")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29670>

1 files changed, 3 insertions, 51 deletions

diff --git a/src/panfrost/ci/panfrost-g52-fails.txt b/src/panfrost/ci/panfrost-g52-fails.txt
index 58ece050261..ae28c59529a 100644
--- a/src/panfrost/ci/panfrost-g52-fails.txt
+++ b/src/panfrost/ci/panfrost-g52-fails.txt
@@ -1179,59 +1179,11 @@ dEQP-VK.pipeline.monolithic.multisample_shader_builtin.sample_mask.pattern.137_1
 dEQP-VK.pipeline.monolithic.multisample_shader_builtin.sample_mask.write.128_128_1.samples_4,Crash
 dEQP-VK.pipeline.monolithic.multisample_shader_builtin.sample_mask.write.137_191_1.samples_4,Crash
 
-# Problems in the image copy logic?
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.height_layers.r8g8b8a8_unorm_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.height_layers.r8g8b8a8_unorm_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.height_layers.r8g8b8a8_unorm_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.height_layers.r8g8b8a8_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.height.r8g8b8a8_unorm_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.height.r8g8b8a8_unorm_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.height.r8g8b8a8_unorm_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.height.r8g8b8a8_unorm,Fail
+# Some huge tests fail to allocate when running several deqp-vk instances. Those pass just fine
+# when executed in isolation. There's still something strange though: the CTS trips out on a NULL
+# VkDeviceMemory when it should report a VK_ERROR. This needs further investigation.
 dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.width_height_layers.r8g8b8a8_unorm_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.width_height_layers.r8g8b8a8_unorm_d24_unorm_s8_uint,Fail
 dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.width_height_layers.r8g8b8a8_unorm_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.width_height_layers.r8g8b8a8_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.width_height.r8g8b8a8_unorm_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.width_height.r8g8b8a8_unorm_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.width_height.r8g8b8a8_unorm_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.2d_array.huge.width_height.r8g8b8a8_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.huge.width_height.r8g8b8a8_unorm_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.huge.width_height.r8g8b8a8_unorm_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.huge.width_height.r8g8b8a8_unorm_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.huge.width_height.r8g8b8a8_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a1r5g5b5_unorm_pack16_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a1r5g5b5_unorm_pack16_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a1r5g5b5_unorm_pack16_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a1r5g5b5_unorm_pack16,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a2b10g10r10_uint_pack32_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a2b10g10r10_uint_pack32_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a2b10g10r10_uint_pack32_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a2b10g10r10_uint_pack32,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a2b10g10r10_unorm_pack32_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a2b10g10r10_unorm_pack32_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a2b10g10r10_unorm_pack32_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.a2b10g10r10_unorm_pack32,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r16g16_sint_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r16g16_sint_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r16g16_sint_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r16g16_sint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r32g32b32a32_sfloat_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r32g32b32a32_sfloat_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r32g32b32a32_sfloat_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r32g32b32a32_sfloat,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r32_uint_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r32_uint_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r32_uint_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r32_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r5g6b5_unorm_pack16_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r5g6b5_unorm_pack16_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r5g6b5_unorm_pack16_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r5g6b5_unorm_pack16,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r8g8b8a8_unorm_d16_unorm,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r8g8b8a8_unorm_d24_unorm_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r8g8b8a8_unorm_d32_sfloat_s8_uint,Fail
-dEQP-VK.pipeline.monolithic.render_to_image.core.cube.small.r8g8b8a8_unorm,Fail
 
 # uprev Piglit in Mesa
 spec@ext_image_dma_buf_import@ext_image_dma_buf_import-refcount-multithread,Crash