diff options
| author | Daniel Stone <daniels@collabora.com> | 2024-08-01 11:18:34 +0100 |
|---|---|---|
| committer | Eric Engestrom <eric@engestrom.ch> | 2024-08-04 22:43:06 +0200 |
| commit | c61862e7aff836995cfc18c6f471c6828900078d (patch) | |
| tree | 430840235726be3c6858b00072a36ae159d65ed4 /src/gbm | |
| parent | fbfcf52c4dab2896dc65833c40dcb3d901c64335 (diff) | |
gbm/dri: Remove erroneous assert
The user is allowed to pass a list of modifiers including
DRM_FORMAT_MOD_INVALID, meaning that the user is OK with implicit
modifiers. Since merging the DRI interfaces, this assert that we are
never returning an implicit modifier is unnecessary and also wrong. It
was originally added to be super-safe, but we now know that our drivers
work very well with modifiers, so don't need it.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Fixes: 0b16d7ebb92e ("dri: Allow INVALID for modifier-less drivers")
Closes: mesa/mesa#11591
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30464>
(cherry picked from commit cd961a7e3fa7140f77495fccf9a523c5a3d84a50)
Diffstat (limited to 'src/gbm')
| -rw-r--r-- | src/gbm/backends/dri/gbm_dri.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index 9ab5e452872..2bd1191a195 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends/dri/gbm_dri.c @@ -1055,9 +1055,6 @@ gbm_dri_bo_create(struct gbm_device *gbm, free(mods_filtered); mods_filtered = NULL; - if (modifiers) - assert(gbm_dri_bo_get_modifier(&bo->base) != DRM_FORMAT_MOD_INVALID); - dri->image->queryImage(bo->image, __DRI_IMAGE_ATTRIB_HANDLE, &bo->base.v0.handle.s32); dri->image->queryImage(bo->image, __DRI_IMAGE_ATTRIB_STRIDE, |