summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFaith Ekstrand <faith.ekstrand@collabora.com>2024-08-26 17:28:44 -0500
committerMarge Bot <emma+marge@anholt.net>2024-08-29 03:30:31 +0000
commitc0191b20de5f41c0c66ac534d6b735275c4916bb (patch)
tree04c739fd3fd075044cd47ca235f652e896cd6701
parent03655dfda12c16f13b0e132282a5ef779b925b93 (diff)
vulkan/pipeline: Handle VIEW_INDEX_FROM_DEVICE_INDEX_BIT
The rehash we're doing here is a bit of a hack but it's a back-portable hack. We'll fix it properly in following commits. Fixes: 9308e8d90d26 ("vulkan: Add generic graphics and compute VkPipeline implementations") Reviewed-by: Ivan Briano <ivan.briano@intel.com> Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30876>
-rw-r--r--src/vulkan/runtime/vk_pipeline.c13
1 files changed, 13 insertions, 0 deletions
diff --git a/src/vulkan/runtime/vk_pipeline.c b/src/vulkan/runtime/vk_pipeline.c
index 6c68b23d6ca..990ec1b3d97 100644
--- a/src/vulkan/runtime/vk_pipeline.c
+++ b/src/vulkan/runtime/vk_pipeline.c
@@ -820,6 +820,16 @@ vk_pipeline_precompile_shader(struct vk_device *device,
uint8_t stage_sha1[SHA1_DIGEST_LENGTH];
vk_pipeline_hash_shader_stage(info, &rs, stage_sha1);
+ /* This bit affects shader compilation but isn't taken into account in
+ * vk_pipeline_hash_shader_stage(). Re-hash the SHA1 if it's set.
+ */
+ if (pipeline_flags & VK_PIPELINE_CREATE_2_VIEW_INDEX_FROM_DEVICE_INDEX_BIT_KHR) {
+ struct mesa_sha1 ctx;
+ _mesa_sha1_init(&ctx);
+ _mesa_sha1_update(&ctx, stage_sha1, sizeof(stage_sha1));
+ _mesa_sha1_final(&ctx, stage_sha1);
+ }
+
if (cache != NULL) {
struct vk_pipeline_cache_object *cache_obj =
vk_pipeline_cache_lookup_object(cache, stage_sha1, sizeof(stage_sha1),
@@ -847,6 +857,9 @@ vk_pipeline_precompile_shader(struct vk_device *device,
if (result != VK_SUCCESS)
return result;
+ if (pipeline_flags & VK_PIPELINE_CREATE_2_VIEW_INDEX_FROM_DEVICE_INDEX_BIT_KHR)
+ NIR_PASS(_, nir, nir_lower_view_index_to_device_index);
+
if (ops->preprocess_nir != NULL)
ops->preprocess_nir(device->physical, nir);