diff options
| author | Ralph Campbell <rcampbell@nvidia.com> | 2018-03-26 14:56:14 -0400 |
|---|---|---|
| committer | Jérôme Glisse <jglisse@redhat.com> | 2018-03-26 15:11:54 -0400 |
| commit | ac531468aac4ef7f95c876620286b7a6b6db4325 (patch) | |
| tree | 49c28eb86a55c9f4c169f48fb2cc45e81b04625b | |
| parent | c936228f0d9bb3af0fe15cfd5773cfa55e6012a2 (diff) | |
mm/hmm: do not ignore specific pte fault flag in hmm_vma_fault()
Save requested fault flags from caller supplied pfns array before
overwritting it with the special none value. Without this we would
not fault on all cases requested by caller, leading to caller calling
us in a loop unless something else did change the CPU page table.
Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Cc: Evgeny Baskakov <ebaskakov@nvidia.com>
Cc: Mark Hairgrove <mhairgrove@nvidia.com>
Cc: John Hubbard <jhubbard@nvidia.com>
| -rw-r--r-- | mm/hmm.c | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -498,10 +498,11 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, bool fault, write_fault; uint64_t cpu_flags; pte_t pte = *ptep; + uint64_t orig_pfn = *pfn; *pfn = range->values[HMM_PFN_NONE]; cpu_flags = pte_to_hmm_pfn_flags(range, pte); - hmm_pte_need_fault(hmm_vma_walk, *pfn, cpu_flags, + hmm_pte_need_fault(hmm_vma_walk, orig_pfn, cpu_flags, &fault, &write_fault); if (pte_none(pte)) { @@ -528,7 +529,7 @@ static int hmm_vma_handle_pte(struct mm_walk *walk, unsigned long addr, range->flags[HMM_PFN_DEVICE_PRIVATE]; cpu_flags |= is_write_device_private_entry(entry) ? range->flags[HMM_PFN_WRITE] : 0; - hmm_pte_need_fault(hmm_vma_walk, *pfn, cpu_flags, + hmm_pte_need_fault(hmm_vma_walk, orig_pfn, cpu_flags, &fault, &write_fault); if (fault || write_fault) goto fault; |