diff options
| author | Alberto Garcia <berto@igalia.com> | 2016-02-18 12:26:56 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2016-02-22 14:08:04 +0100 |
| commit | 45b2d418e05e8b3cce9c8370ef6daac4b073b57a (patch) | |
| tree | 4bcebda5c925398f33c777066b6fd1317d43d16f /util/throttle.c | |
| parent | 6921b1809507797752b039b2892fc33bf6bccb7e (diff) | |
throttle: Make throttle_max_is_missing_limit() set errp
The caller does not need to set it, and this will allow us to refactor
this function later.
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'util/throttle.c')
| -rw-r--r-- | util/throttle.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/util/throttle.c b/util/throttle.c index 564e13261e..77010b4a1a 100644 --- a/util/throttle.c +++ b/util/throttle.c @@ -306,13 +306,16 @@ bool throttle_is_valid(ThrottleConfig *cfg) /* check if bps_max/iops_max is used without bps/iops * @cfg: the throttling configuration to inspect + * @errp: error object */ -bool throttle_max_is_missing_limit(ThrottleConfig *cfg) +bool throttle_max_is_missing_limit(ThrottleConfig *cfg, Error **errp) { int i; for (i = 0; i < BUCKETS_COUNT; i++) { if (cfg->buckets[i].max && !cfg->buckets[i].avg) { + error_setg(errp, "bps_max/iops_max require corresponding" + " bps/iops values"); return true; } } |