diff options
| author | Mark McLoughlin <markmc@redhat.com> | 2009-09-23 11:24:05 +0100 |
|---|---|---|
| committer | Blue Swirl <blauwirbel@gmail.com> | 2009-09-25 19:57:51 +0000 |
| commit | 3df04ac3c63ba6a0ff7417e0f7dd389bc3efb09d (patch) | |
| tree | fddfd3db38eec559bedd3791344d662f3c7013c6 /qemu-option.c | |
| parent | 9262f3841b0ecb866568e3edcc1fee1b05d41e9f (diff) | |
Fix coding style issue
Replace:
if (-1 == foo())
with:
if (foo() == -1)
While this coding style is not in direct contravention of our currently
ratified CODING_STYLE treaty, it could be argued that the Article 3 of
the European Convention on Human Rights (prohibiting torture and "inhuman
or degrading treatment") reads on the matter.
[This commit message was brought to you without humour, as is evidenced
by the absence of any emoticons]
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Cc: Avi Kivity <avi@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Diffstat (limited to 'qemu-option.c')
| -rw-r--r-- | qemu-option.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/qemu-option.c b/qemu-option.c index 88298e4b51..9fe1f95479 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -267,7 +267,7 @@ int set_option_parameter(QEMUOptionParameter *list, const char *name, // Process parameter switch (list->type) { case OPT_FLAG: - if (-1 == parse_option_bool(name, value, &flag)) + if (parse_option_bool(name, value, &flag) == -1) return -1; list->value.n = flag; break; @@ -282,7 +282,7 @@ int set_option_parameter(QEMUOptionParameter *list, const char *name, break; case OPT_SIZE: - if (-1 == parse_option_size(name, value, &list->value.n)) + if (parse_option_size(name, value, &list->value.n) == -1) return -1; break; @@ -745,7 +745,7 @@ int qemu_opts_do_parse(QemuOpts *opts, const char *params, const char *firstname } if (strcmp(option, "id") != 0) { /* store and parse */ - if (-1 == qemu_opt_set(opts, option, value)) { + if (qemu_opt_set(opts, option, value) == -1) { return -1; } } |