From f70cfc8f90091ef0f5ed0a5b2e023e7fd6369b36 Mon Sep 17 00:00:00 2001 From: Kristian Høgsberg Date: Thu, 2 Apr 2009 17:30:19 -0400 Subject: Don't stomp on dixLookupDrawable() return value in DoCreateGLXPixmap(). --- glx/glxcmds.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/glx/glxcmds.c b/glx/glxcmds.c index 7197204ef..ec122407b 100644 --- a/glx/glxcmds.c +++ b/glx/glxcmds.c @@ -1106,7 +1106,11 @@ DoCreateGLXPixmap(ClientPtr client, __GLXscreen *pGlxScreen, __GLXconfig *config int err; err = dixLookupDrawable(&pDraw, drawableId, client, 0, DixAddAccess); - if (err != Success || pDraw->type != DRAWABLE_PIXMAP) { + if (err != Success) { + client->errorValue = drawableId; + return err; + } + if (pDraw->type != DRAWABLE_PIXMAP) { client->errorValue = drawableId; return BadPixmap; } -- cgit v1.2.3