diff options
| author | Ilia Mirkin <imirkin@alum.mit.edu> | 2013-07-19 06:27:45 -0400 |
|---|---|---|
| committer | Ben Skeggs <bskeggs@redhat.com> | 2013-07-30 13:00:37 +1000 |
| commit | 81a731dff5da4ea999a7efd5da5bba829beebc83 (patch) | |
| tree | 8b57d9582d621d03f05b2e77c02a0255583ba604 | |
| parent | 115ff3b5b45c1756d841cdb8837f89c7c5a09f47 (diff) | |
core: xtensa firmware size needs to be 0x40000 no matter what
The current logic is wrong since we send fw->size >> 8 to the
card. Rounding the size up by 0x100 and 0x1000 didn't seem to help,
the card still hung, so go back to what the blob does -- 0x40000.
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>
| -rw-r--r-- | nvkm/engine/xtensa.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/nvkm/engine/xtensa.c b/nvkm/engine/xtensa.c index 0639bc59..5f6ede7c 100644 --- a/nvkm/engine/xtensa.c +++ b/nvkm/engine/xtensa.c @@ -118,7 +118,13 @@ _nouveau_xtensa_init(struct nouveau_object *object) return ret; } - ret = nouveau_gpuobj_new(object, NULL, fw->size, 0x1000, 0, + if (fw->size > 0x40000) { + nv_warn(xtensa, "firmware %s too large\n", name); + release_firmware(fw); + return -EINVAL; + } + + ret = nouveau_gpuobj_new(object, NULL, 0x40000, 0x1000, 0, &xtensa->gpu_fw); if (ret) { release_firmware(fw); |