[cairo-error] Clean up all the warnings and missing _cairo_error() calls.

Every time we assign or return a hard-coded error status wrap that value
with a call to _cairo_error(). So the idiom becomes:
    status = _cairo_error (CAIRO_STATUS_NO_MEMORY);
or
    return _cairo_error (CAIRO_STATUS_INVALID_DASH);

This ensures that a breakpoint placed on _cairo_error() will trigger
immediately cairo detects the error.

1 files changed, 2 insertions, 4 deletions

diff --git a/src/cairo-spline.c b/src/cairo-spline.c
index f22f64649..898ce7c31 100644
--- a/src/cairo-spline.c
+++ b/src/cairo-spline.c
@@ -117,10 +117,8 @@ _cairo_spline_grow (cairo_spline_t *spline)
 	       	                        new_size, sizeof (cairo_point_t));
     }
 
-    if (new_points == NULL) {
-	_cairo_error (CAIRO_STATUS_NO_MEMORY);
-	return CAIRO_STATUS_NO_MEMORY;
-    }
+    if (new_points == NULL)
+	return _cairo_error (CAIRO_STATUS_NO_MEMORY);
 
     spline->points = new_points;
     spline->points_size = new_size;