From 4b1041a90eb5246a0d9cb758f8b345fe8ee538e5 Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Tue, 5 Sep 2006 09:44:20 +0000 Subject: Fix possible buffer overflow that would cause a crash in the ASF 2006-09-05 Bastien Nocera * src/plparse/totem-pl-parser.c: (totem_pl_parser_is_asf): Fix possible buffer overflow that would cause a crash in the ASF recognition code (Closes: #354284) --- ChangeLog | 6 ++++++ src/plparse/totem-pl-parser.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 8a0860d0..145641a6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2006-09-05 Bastien Nocera + + * src/plparse/totem-pl-parser.c: (totem_pl_parser_is_asf): + Fix possible buffer overflow that would cause a crash in the + ASF recognition code (Closes: #354284) + 2006-09-04 Bastien Nocera * configure.in: the nautilus extension requires gtk-2.0, not diff --git a/src/plparse/totem-pl-parser.c b/src/plparse/totem-pl-parser.c index c58e390a..47854180 100644 --- a/src/plparse/totem-pl-parser.c +++ b/src/plparse/totem-pl-parser.c @@ -2048,7 +2048,7 @@ totem_pl_parser_is_asf (const char *data, gsize len) g_warning ("Couldn't dup data in totem_pl_parser_is_asf"); return FALSE; } - buffer[len] = '\0'; + buffer[len - 1] = '\0'; if (strstr (buffer, "