diff options
| author | Nirbheek Chauhan <nirbheek@centricular.com> | 2016-10-03 20:22:53 +0530 |
|---|---|---|
| committer | Nirbheek Chauhan <nirbheek@centricular.com> | 2016-10-13 03:40:04 +0530 |
| commit | 6c1bc80d2791af9a5b07d59ce8e6f7039577eece (patch) | |
| tree | 11676a9b5fb069d2b296a36614030de5c78cb5ab /configure.ac | |
| parent | 0ab950f501ef1cb6ee1a786aaf473261ae3fed58 (diff) | |
build: Fix clock_gettime check with XCode 8
With XCode 8, clock_gettime will be incorrectly detected as being
available regardless of what OS X version we're targetting because the
symbol is available in the .tbd library as a weak symbol.
See: https://github.com/Homebrew/homebrew-core/issues/3727#issue-170086273
It's only starting from macOS 10.12 that clock_gettime is actually
available, so we can unconditionally disable it when targetting older
versions. We cannot simply do AC_CHECK_FUNCS with -Wl,-no_weak_imports
because the autoconf check does its own prototype declaration that
doesn't trigger that compiler flag.
https://bugzilla.gnome.org/show_bug.cgi?id=772451
Diffstat (limited to 'configure.ac')
| -rw-r--r-- | configure.ac | 38 |
1 files changed, 35 insertions, 3 deletions
diff --git a/configure.ac b/configure.ac index bf14e2b3b..1f78e4f07 100644 --- a/configure.ac +++ b/configure.ac @@ -671,18 +671,50 @@ AC_CHECK_FUNCS([posix_memalign]) AC_CHECK_FUNCS([getpagesize]) dnl Check for POSIX timers -AC_CHECK_FUNCS(clock_gettime, [], [ +CLOCK_GETTIME_FOUND="no" +AC_CHECK_FUNC(clock_gettime, [CLOCK_GETTIME_FOUND="yes"], [ AC_CHECK_LIB(rt, clock_gettime, [ - AC_DEFINE(HAVE_CLOCK_GETTIME, 1) + CLOCK_GETTIME_FOUND="yes" LIBS="$LIBS -lrt" ], [ AC_CHECK_LIB(pthread, clock_gettime, [ - AC_DEFINE(HAVE_CLOCK_GETTIME, 1) + CLOCK_GETTIME_FOUND="yes" LIBS="$LIBS -lpthread" ]) ]) ]) +# With XCode 8, clock_gettime will be incorrectly detected as being available +# regardless of what version of OS X you target because the symbol is available +# in the .tbd file as a weak symbol. +# See: https://bugzilla.gnome.org/show_bug.cgi?id=772451 +# +# We cannot simply do AC_CHECK_FUNCS with -Wl,-no_weak_imports because the +# autoconf check does its own prototype declaration that doesn't trigger that +# compiler flag. +# +# It's only starting from macOS 10.12, that clock_gettime is actually available, +# so we can unconditionally disable it when targetting older versions. +case "$host_os" in + darwin*) + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[ +#include <AvailabilityMacros.h> +#if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_12 +#error "Not compiling for OS X 10.12 or later" +#endif + ]])], [], [ + if test "$CLOCK_GETTIME_FOUND" = "yes"; then + AC_MSG_NOTICE([Disabling incorrectly detected clock_gettime on OS X]) + fi + CLOCK_GETTIME_FOUND="no" + ]) + ;; +esac + +if test "$CLOCK_GETTIME_FOUND" = "yes"; then + AC_DEFINE(HAVE_CLOCK_GETTIME, 1, [Have clock_gettime]) +fi + AC_CACHE_CHECK(for posix timers, gst_cv_posix_timers, AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ #include <time.h> |