diff options
| author | Vineeth TM <vineeth.tm@samsung.com> | 2015-07-27 08:46:01 +0900 |
|---|---|---|
| committer | Thibault Saunier <tsaunier@gnome.org> | 2015-10-02 17:46:51 +0200 |
| commit | aa2c93c3d4f1663a0efe8c421fc95c0134092943 (patch) | |
| tree | 8118a8bd4df25783daee6a7dc6d8de8e8a52e1ed | |
| parent | e7b65fe5df4c24dca33445ab9105bf5b5c5865a5 (diff) | |
validate:launcher: throw valgrind error only for definite loss
errors-for-leak-kinds should be set to definite, because almost every test case
, will have possibly lost memory, which may or may not be a leak.
And throwing error for all these cases doesn't seem to be correct.
https://bugzilla.gnome.org/show_bug.cgi?id=752754
| -rw-r--r-- | validate/launcher/baseclasses.py | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/validate/launcher/baseclasses.py b/validate/launcher/baseclasses.py index b9b0aeb..0affd4d 100644 --- a/validate/launcher/baseclasses.py +++ b/validate/launcher/baseclasses.py @@ -316,6 +316,9 @@ class Test(Loggable): ('tool', 'memcheck'), ('leak-check', 'full'), ('leak-resolution', 'high'), + # TODO: errors-for-leak-kinds should be set to all instead of definite + # and all false positives should be added to suppression files. + ('errors-for-leak-kinds', 'definite'), ('num-callers', '20'), ('log-file', '"' + vglogsfile + '"'), ('error-exitcode', str(VALGRIND_ERROR_CODE)), |