| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
|
|
correctly once the user clicks apply.
Issue : By default, EnableUI config parameter is true for 5.0 drivers.
nvidia-settings writes "EnableUI=TRUE" to gridd.conf file if the user
has applied license via UI. Since the user config options in gridd.conf
persist on driver upgrade we see the UI is enabled with 5.1 drivers.
The same issue is also encountered on driver upgrade from 5.0 to 6.0
Fix : User has to manually delete the gridd.conf file and create a new one with
the gridd.conf.template file provided.
Made the following changes:
1. On launching nvidia-settings, if there is no gridd.conf file available,
no new gridd.conf file will be created. A new gridd.conf file will be
created only when user clicks apply button via UI.
2. While updating the griddConfig structure with the user provided values
from UI, the corresponding config parameter will be updated only if it
differs from the currently provided value by the user.
|
|
"Tesla(unlicensed)" string to "GRID Virtual Apps"
Details:
- From nvidia-gridd, fetching license state from the state machine. Sending this
license state instead of license status to nvidia-settings.
- According to license state and featureType fetched from nvidia-gridd, setting
license status on nvidia-settings side.
- Updated all license status messages to latest reviewed strings.
- Renamed "Tesla(unlicensed)" string to "GRID Virtual Apps".
|
|
page of nvidia-settings:
Issue:
Apply/Cancel button is disabled post moving from "Quadro Virtual" "Datacenter
Workstation" license edition to "Unlicensed Tesla" license edition.
Fix:
Apply/Cancel buttons are enabled only under following cases:
* If the License Edition has changed, that is the corresponding feature type
selection has changed.
* If any of the textbox entry has changed.
Also updating the license Acquiring, unlicensed and failed message strings on UI
according to the feature type selection.
|
|
Simple change to add a couple combinations of 32 display options to the SLI
Mosaic Grid Config dropdown
|
|
Issue:
When nvidia-settings is launched on a Quadro vDWS Edition licensed VM, the
message shown on 'Manage GRID License' page as well as the one logged in
/var/log/messages incorrectly states that the system has switched to Tesla
(unlicensed) and user needs to reboot the system.
Root cause and fix:
Issue was observed because the feature type was not set correctly on page
creation. Fixed it with this change.
Testing done:
Verified on NMOS and vGPU setup,correct feature type is displayed in the message
over UI and in /var/log/messages as well.
|
|
|
|
It had been requested to provide end users with a way to test if stereo mode has
been configured and is working properly.
To address such, it was decided to create a simple demo/test and to get such app
embedded in nvidia settings by creating a custom gtk widget on which to render
opengl. (Such widget seems to exist, but only in versions of gtk3 that are newer
to what nvidia-settings use, hence the need to create our own).
This implementation will work with gtk3 and ignored on gtk2.
|
|
|
|
This change adds a new stereo mode (14) to represent the current combination of
stereo mode 3 with InbandStereoSignaling.
|
|
|
|
|
|
|
|
* Added a new cancel button, which clears all changes made in the fields.
* If Primary server address is empty:
* Apply/Cancel buttons and Secondary server address/port disabled.
* Enable Apply/Cancel buttons and Secondary server address/port only
when there is text entered in Primary server address textbox to nofity
user that Primary server address is mandatory.
* If Primary server address is non-empty:
* User can edit Secondary server address/port.
* Apply/Cancel buttons Grayed out after applying click.
* Enable Apply/Cancel buttons when text entered in any of the textboxes is
different than the earlier entered text.
* On launch of 'Manage License' page, Apply/Cancel buttons are disabled.
Testing done:
Verified the above modified functionality of 'Manage License' page on NMOS and vGPU.
|
|
|
|
|
|
Configuration
Currently when the Display Configuration page of nvidia-settings is in Basic mode, any changes to the Rotation and Reflection values are applied to all modes for that display. This causes our entire list of metamodes to be updated and when we cancel a modeset, those updated metamodes are not reverted. Even if we do revert them on the server, our internal data structures do not represent these metamodes and resetting the UI to force a sync would cause the loss of all user config options currently chosen but not applied.
This change modifies the behavior of Basic Mode configurations that involve rotation and reflection. These changes will make these metamode changes to behave similarly to advanced mode changes in that they will only affect the current metamode. On the UI side, in basic mode, we will make sure that if rotation/reflection is selected and the resolution is changed (effectively changing to a different selected mode) we will make sure the adjustments are carried over to the new mode.
A user using the UI exclusively should not see any changes in behavior aside from the actual issue fixed. A user checking the available metamodes on the server would see a difference but it would be identical to the metamodes given by the unchanged Configuration method in Advanced Mode.
|
|
This change adds help text for the "Save Current Configuration" button on the "nvidia-settings Configuration" page and re-enables a flag that allows the help text for "Sync to this display device" on the XVideo Settings page.
Also removes the per entry tooltip text for the "Sync to this display device" and adds the tooltip to the entire container widget since it exists for the entire lifetime of the application.
|
|
The variable on this change are liable to not be initialized if the
function that is meant to initialize errors out. And the uninitialized
variable would still be passed for the creation of a widget. Since in
the case of this happening such widget won't be used anyways, chances
of this causing trouble are slim, but still we shouldn't have it.
Additionally it shows on valgrind so it creates noise when trying to
troubleshoot something else.
|
|
Right now, the Enable Mosaic button is only validated properly and shown when a Display object is selected on the Display Config page of nvidia-settings. Mosaic support is a feature of the gpu and shouldn't depend on if a Display or Screen is selected. This change adds the validation and activation of the Mosaic feature with a Screen selection in addition to the existing Display selection.
|
|
Currently, we can get in a situation where the nvidia-settings display layout window is setup to be larger than what the X server allows. The problem is if we are in this situation, the user may not be able to fix the layout because our enforcement of size limits doesn't allow the user to move displays to the origin. This is because when moving items to the left or upward, we calculate our movement limit with respect to the right-most or furthest down position used.
This change will allow us to always move items to the origin. Note that we already always redefine the origin to be the top-left most valid item. This position should always be available when moving items.
|
|
status.
Anytime the ECC Pending Status Checkbox is set to a different value than the ECC Default Configuration value, this button should be enabled. It should be clear to the user that what the Reset button's value should be based on behavior alone.
This change updates the enabled/disabled state of the Reset anytime we receive a update to the pending config value and or when the user changes the value manually.
|
|
This saves a couple dozen KB.
-rwxr-xr-x 1 aaron aaron 1481192 May 18 16:11 libnvidia-gtk2.so.old
-rwxr-xr-x 1 aaron aaron 1452520 May 18 16:11 libnvidia-gtk2.so
-rwxr-xr-x 1 aaron aaron 1477384 May 18 16:11 libnvidia-gtk3.so.old
-rwxr-xr-x 1 aaron aaron 1444616 May 18 16:11 libnvidia-gtk3.so
|
|
Create a helper function, ctk_pixbuf_from_data(), and corresponding helper macro
CTK_LOAD_PIXBUF(), to load embedded images from their internal PNG
representation. Delete the uncompressed pixdata versions.
This saves a few hundred KB from each of libnvidia-gtk2 and libnvidia-gtk3:
-rwxr-xr-x 1 aaron aaron 1828552 May 18 16:06 libnvidia-gtk2.so.old
-rwxr-xr-x 1 aaron aaron 1481192 May 18 16:07 libnvidia-gtk2.so
-rwxr-xr-x 1 aaron aaron 1820808 May 18 16:06 libnvidia-gtk3.so.old
-rwxr-xr-x 1 aaron aaron 1477384 May 18 16:07 libnvidia-gtk3.so
|
|
These will be used later to decompress the images at runtime.
Generate headers that define the start and end symbols for these.
|
|
Right now on the ECC status page in nvidia-settings we poll for changes in the ECC state of the GPU. When ECC is enabled we poll for ECC errors. The problem is we only check the Configuration Pending state when the application starts up. We can detect via nvcontrol events, if this value is changed for example on the command line by "nvidia-settings -a ECCConfiguration=1". But if this value is changed by a non-nvcontrol method like "nvidia-smi -e 1", we don't detect or display the change.
This change adds querying this value to the polling loop of the ECC Status page.
|
|
Recognize the new flag in nvidia-settings in order to be able to write it to
xorg.conf.
|
|
independently.
On few SKU users can only set graphics clock offset and not memory clock offset.
So updated UI to show memory clock offset and graphics clock offset, if either is editable.
|
|
|
|
Datacenter Workstation' in the manage license page and help page of nvidia-settings.
|
|
|
|
This change adds support for reporting the framelock firmware minor version via
nvidia-settings.
Tested with firmware version 2.99, and also tested with the firmware minor
version hardcoded to 1 just to doublecheck the formatting.
|
|
|
|
Issue:
if dbus connection has failed and nvidia-gridd is already running,
still nvidia-settings incorrectly reports error message to make sure whether "nvidia-gridd is running"
while applying license.
Fix:
modified the error message shown in nvidia-settings
in case of failure to make sure we inform user to check if both nvidia-gridd
and dbus-daemon are running.
|
|
nvidia-settings: As "Manage GRID License" page will be displayed only on GRID platform with GRID packages installed, so renamed Licensing Page link to "Manage License" to maintain the consistency of name across Windows and Linux.
Testing done:
Verified successfully that the modified string "Manage License" is displayed
in Linux nvidia-settings.
|
|
|
|
|
|
Issue:
For the users who doesnot have permission to configure license settings, no
message/pop-up is shown to the user if tries to apply license via nvidia-settings.
Fix:
When write operation on gridd config file fails, a pop-up box is displayed
with error message.
|
|
Tesla(unlicensed) by default
If featureType is not supported, Tesla(unlicensed) will be selected.
|
|
Descriptions of some of the existing fields is corrected in help page for Manage GRID License page.
|
|
Issue:
Getting assertion on lauching nvidia-settings when nvidia-gridd is not running:
"ERROR: GRID License dbus communication: Argument is not int! "
Fix:
The current dbus API queues a message to send(dbus_connection_send_with_reply)
and block until we receive a reply.
Now changed the dbus API(dbus_connection_send_with_reply_and_block)
which sends a message and blocks for a default time period while waiting for a reply.
This dbus function has advantage over the current API as it returns an error code on failure.
And depending on the error code returned we can decide whether to send the signal to nvidia-gridd or not.
|
|
Due to check DBUS_REQUEST_NAME_REPLY_PRIMARY_OWNER only primary owner was showing the page. Now updated code to remove the check so all instances will show the page. And when apply button clicked the server name/port number values get applied.
|
|
Fix: Added a Null check for griddConfig.
|
|
|
|
license feature types.
Issue :
If nvidia-gridd is not running, no license state is received and hence default
message strings set in nvidia-settings are shown. The default unlicensed message
string was generic.
Fix :
Defined different values for feature types to avoid confusion between virtualization
mode and feature types.
Assigned different default unlicensed message strings in nvidia-settings according
to feature types.
Removed mapping table with nvml for feature types as feature types are used by user
only.
|
|
contents of help page for Manage GRID License page are updated to incorporate new fields and descriptions of some of the existing fields is corrected.
|
|
nvidia-settings
Through this change:
1. Server Address fields will not allow entry of whitespace characters.
2. Port Number fields will only allow entry of digits.
|
|
Currently we pass &status as the data pointer to dbus_message_iter_get_basic call.
'status' is already of the type (gint *).
This commit changes the call so that it passes pStatus directly.
It also changes the name of the variable to pStatus to avoid any confusion.
|
|
|
