diff options
author | José Fonseca <jfonseca@vmware.com> | 2014-02-28 14:45:32 +0000 |
---|---|---|
committer | José Fonseca <jfonseca@vmware.com> | 2014-02-28 14:45:32 +0000 |
commit | 3522cbdf837a4c825ff393e570f84e5093e57db2 (patch) | |
tree | d47b34630287c6e0b1a63a224d49eb26cec5468f /wrappers/gltrace.py | |
parent | 8c3fa76429cdbc366f95b124c2174001f949f43a (diff) |
gltrace: Warn about coherent/pinned memory mappings being unsupported.
See issue #232.
Diffstat (limited to 'wrappers/gltrace.py')
-rw-r--r-- | wrappers/gltrace.py | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/wrappers/gltrace.py b/wrappers/gltrace.py index beb53af8..96c71efc 100644 --- a/wrappers/gltrace.py +++ b/wrappers/gltrace.py @@ -651,6 +651,17 @@ class GlTracer(Tracer): self.emit_memcpy('(char *)map + offset', '(const char *)map + offset', 'length') print ' }' + # FIXME: We don't support coherent/pinned memory mappings + # See https://github.com/apitrace/apitrace/issues/232 + if function.name in ('glBufferStorage', 'glNamedBufferStorageEXT'): + print r' if (flags & GL_MAP_COHERENT_BIT) {' + print r' os::log("apitrace: warning: coherent mappings not fully supported\n");' + print r' }' + if function.name in ('glBufferData', 'glBufferDataARB'): + print r' if (target == GL_EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD) {' + print r' os::log("apitrace: warning: GL_AMD_pinned_memory not fully supported\n");' + print r' }' + # Don't leave vertex attrib locations to chance. Instead emit fake # glBindAttribLocation calls to ensure that the same locations will be # used when retracing. Trying to remap locations after the fact would |