diff options
| author | Mark Janes <mark.a.janes@intel.com> | 2016-08-26 14:02:16 -0700 |
|---|---|---|
| committer | Mark Janes <mark.a.janes@intel.com> | 2017-06-19 14:04:47 -0700 |
| commit | 197eac20c8ebd411fdc3fe1639215540d845378c (patch) | |
| tree | e898afe33d659b50d458ef345ad0768857687e79 /retrace/daemon/glframe_retrace.hpp | |
| parent | e0f3cf4e501b44229507f9933f7a17b580d66069 (diff) | |
Improve robustness of retrace
Adding error handling for retrace eliminates crashes in the cases where
ApiTrace cannot provide a rendertarget image. In the course of testing
this, I fixed several retrace bugs.
The other issue with retrace was that retracing gets behind when tracing
large rendertargets. The current selection count is sent with the
request, so the retrace thread can discard requests that have been
surpassed by new selections during the time they were enqueued.
Diffstat (limited to 'retrace/daemon/glframe_retrace.hpp')
| -rw-r--r-- | retrace/daemon/glframe_retrace.hpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/retrace/daemon/glframe_retrace.hpp b/retrace/daemon/glframe_retrace.hpp index f1a73394..01b99684 100644 --- a/retrace/daemon/glframe_retrace.hpp +++ b/retrace/daemon/glframe_retrace.hpp @@ -67,7 +67,8 @@ class FrameRetrace : public IFrameRetrace { // TODO(majanes) move to frame state tracker int getRenderCount() const; // std::vector<int> renderTargets() const; - void retraceRenderTarget(RenderId renderId, + void retraceRenderTarget(SelectionId selectionCount, + RenderId renderId, int render_target_number, RenderTargetType type, RenderOptions options, |