rendertarget: eliminate redundant rt callbacks

retraceRenderTarget provides exactly one image after all selected
renders have been retraced.  An implementation bug called back after
each linear selection series.

1 files changed, 18 insertions, 17 deletions

diff --git a/retrace/daemon/glframe_retrace.cpp b/retrace/daemon/glframe_retrace.cpp
index 9aeb16eb..fb53796c 100644
--- a/retrace/daemon/glframe_retrace.cpp
+++ b/retrace/daemon/glframe_retrace.cpp
@@ -227,25 +227,26 @@ FrameRetrace::retraceRenderTarget(ExperimentId experimentCount,
         ++current_render_id;
       }
     }
+  }
 
-    Image *i = glstate::getDrawBufferImage(0);
-    if (!i) {
-      GRLOGF(WARN, "Failed to obtain draw buffer image for render id: %d",
-             current_render_id());
-      if (callback)
-        callback->onError("Failed to obtain draw buffer image");
-    } else {
-      std::stringstream png;
-      i->writePNG(png);
-
-      std::vector<unsigned char> d;
-      const int bytes = png.str().size();
-      d.resize(bytes);
-      memcpy(d.data(), png.str().c_str(), bytes);
-      if (callback)
-        callback->onRenderTarget(selection.id, experimentCount, d);
-    }
+  Image *i = glstate::getDrawBufferImage(0);
+  if (!i) {
+    GRLOGF(WARN, "Failed to obtain draw buffer image for render id: %d",
+           current_render_id());
+    if (callback)
+      callback->onError("Failed to obtain draw buffer image");
+  } else {
+    std::stringstream png;
+    i->writePNG(png);
+
+    std::vector<unsigned char> d;
+    const int bytes = png.str().size();
+    d.resize(bytes);
+    memcpy(d.data(), png.str().c_str(), bytes);
+    if (callback)
+      callback->onRenderTarget(selection.id, experimentCount, d);
   }
+
   // play to the rest of the frame
   while (current_render_id.index() < m_renders.size()) {
     m_renders[current_render_id.index()]->retraceRenderTarget(m_tracker,