From c4ffce4dc84a0a9d134a59b7e7765c99ed767e53 Mon Sep 17 00:00:00 2001 From: Eamon Walsh Date: Tue, 22 Sep 2009 13:13:03 -0700 Subject: xace: Relax permissions on XkbGetState from Read to Getattr. This request is used to get the current keyboard group and is called from GTK. It does not return an actual keymap (aside from modifiers) so it should be safe to relax the permission on it. However it does return button state information which should be controlled through a separate pointer Read check. Signed-off-by: Eamon Walsh --- xkb/xkb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xkb/xkb.c b/xkb/xkb.c index 7abbeaaff..98e879ddb 100644 --- a/xkb/xkb.c +++ b/xkb/xkb.c @@ -554,7 +554,7 @@ ProcXkbGetState(ClientPtr client) if (!(client->xkbClientFlags&_XkbClientInitialized)) return BadAccess; - CHK_KBD_DEVICE(dev, stuff->deviceSpec, client, DixReadAccess); + CHK_KBD_DEVICE(dev, stuff->deviceSpec, client, DixGetAttrAccess); xkb= &dev->key->xkbInfo->state; bzero(&rep,sizeof(xkbGetStateReply)); -- cgit v1.2.3