From 7ef95da8a3e22e710882590fc47d56893159cb5d Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Mon, 3 Apr 2006 01:51:54 +0000 Subject: Coverity #616: Fix a rare memory leak. --- ChangeLog | 5 +++++ hw/xnest/Pixmap.c | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 5b0decbe8..4df3ec605 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-04-02 Adam Jackson + + * hw/xnest/Pixmap.c: + Coverity #616: Fix a rare memory leak. + 2006-04-02 Adam Jackson * os/xdmauth.c: diff --git a/hw/xnest/Pixmap.c b/hw/xnest/Pixmap.c index 30ffbc6e6..046b73976 100644 --- a/hw/xnest/Pixmap.c +++ b/hw/xnest/Pixmap.c @@ -102,7 +102,10 @@ xnestPixmapToRegion(PixmapPtr pPixmap) pReg = REGION_CREATE(pPixmap->drawable.pScreen, NULL, 1); pTmpReg = REGION_CREATE(pPixmap->drawable.pScreen, NULL, 1); - if(!pReg || !pTmpReg) return NullRegion; + if(!pReg || !pTmpReg) { + XDestroyImage(ximage); + return NullRegion; + } for (y = 0; y < pPixmap->drawable.height; y++) { Box.y1 = y; -- cgit v1.2.3