diff options
| author | Daniel Drake <drake@endlessm.com> | 2013-12-30 16:52:14 -0600 |
|---|---|---|
| committer | Daniel Drake <drake@endlessm.com> | 2014-01-06 16:15:58 -0600 |
| commit | 7d1611f666355fd784042b91996815f8c6bdade1 (patch) | |
| tree | 143e92607aa325cc316546c952d9d5137054a19b | |
| parent | 2579e48f2116737e2a98acfb839ceda97bea1b09 (diff) | |
Discourage server grabs
Server grabs are not as evil as you might expect, but there is agreement
in that their usage should be limited.
Server grabs can cause things to go rather wrong when mutter emits
a signal while it has grabbed the server. If the receiver of that signal
waits for a synchronous action performed by another client, then you
have a deadlock. This happens with Mali binary GLESv2 drivers :(
https://bugzilla.gnome.org/show_bug.cgi?id=721345
| -rw-r--r-- | src/core/display.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/src/core/display.c b/src/core/display.c index 8a37e7d3..b37bd73c 100644 --- a/src/core/display.c +++ b/src/core/display.c @@ -1224,7 +1224,18 @@ meta_display_screen_for_x_screen (MetaDisplay *display, return NULL; } -/* Grab/ungrab routines taken from fvwm */ +/* Grab/ungrab routines taken from fvwm. + * Calling this function will cause X to ignore all other clients until + * you ungrab. This may not be quite as bad as it sounds, yet there is + * agreement that avoiding server grabs except when they are clearly needed + * is a good thing. + * + * If you do use such grabs, please clearly explain the necessity for their + * usage in a comment. Try to keep their scope extremely limited. In + * particular, try to avoid emitting any signals or notifications while + * a grab is active (if the signal receiver tries to block on an X request + * from another client at this point, you will have a deadlock). + */ void meta_display_grab (MetaDisplay *display) { |